Changeset 252864 in webkit

Timestamp:

Nov 25, 2019 10:15:50 AM (4 years ago)

Author:

commit-queue@webkit.org

Message:

Support OffscreenCanvas as a CanvasImageSource type in CanvasDrawImage, CanvasFillStrokeStyles
​https://bugs.webkit.org/show_bug.cgi?id=182921

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2019-11-25
Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

• web-platform-tests/offscreen-canvas/compositing/2d.composite.globalAlpha.canvas-expected.txt:
• web-platform-tests/offscreen-canvas/compositing/2d.composite.globalAlpha.canvas.worker-expected.txt:
• web-platform-tests/offscreen-canvas/compositing/2d.composite.globalAlpha.canvascopy-expected.txt:
• web-platform-tests/offscreen-canvas/compositing/2d.composite.globalAlpha.canvascopy.worker-expected.txt:
• web-platform-tests/offscreen-canvas/compositing/2d.composite.globalAlpha.canvaspattern-expected.txt:
• web-platform-tests/offscreen-canvas/compositing/2d.composite.globalAlpha.canvaspattern.worker-expected.txt:
• web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.copy-expected.txt:
• web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.copy.worker-expected.txt:
• web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.destination-atop-expected.txt:
• web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.destination-atop.worker-expected.txt:
• web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.destination-in-expected.txt:
• web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.destination-in.worker-expected.txt:
• web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.source-in-expected.txt:
• web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.source-in.worker-expected.txt:
• web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.source-out-expected.txt:
• web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.source-out.worker-expected.txt:
• web-platform-tests/offscreen-canvas/conformance-requirements/2d.voidreturn-expected.txt:
• web-platform-tests/offscreen-canvas/conformance-requirements/2d.voidreturn.worker-expected.txt:
• web-platform-tests/offscreen-canvas/convert-to-blob/offscreencanvas.convert.to.blob.w-expected.txt:
• web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.canvas-expected.txt:
• web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.canvas.worker-expected.txt:
• web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.self.1-expected.txt:
• web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.self.1.worker-expected.txt:
• web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.self.2-expected.txt:
• web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.self.2.worker-expected.txt:
• web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.zerocanvas-expected.txt:
• web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.zerocanvas.worker-expected.txt:
• web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.canvas-expected.txt:
• web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.canvas.worker-expected.txt:
• web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.nocontext-expected.txt:
• web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.nocontext.worker-expected.txt:
• web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.zerocanvas-expected.txt:
• web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.zerocanvas.worker-expected.txt:
• web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.modify.canvas1-expected.txt:
• web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.modify.canvas1.worker-expected.txt:
• web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.modify.canvas2-expected.txt:
• web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.modify.canvas2.worker-expected.txt:
• web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.paint.orientation.canvas-expected.txt:
• web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.paint.orientation.canvas.worker-expected.txt:
• web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.case-expected.txt:
• web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.case.worker-expected.txt:
• web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.null-expected.txt:
• web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.null.worker-expected.txt:
• web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.nullsuffix-expected.txt:
• web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.nullsuffix.worker-expected.txt:
• web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.undefined-expected.txt:
• web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.undefined.worker-expected.txt:
• web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.unrecognised-expected.txt:
• web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.unrecognised.worker-expected.txt:
• web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.unrecognisednull-expected.txt:
• web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.unrecognisednull.worker-expected.txt:
• web-platform-tests/offscreen-canvas/image-smoothing/image.smoothing-expected.txt:
• web-platform-tests/offscreen-canvas/image-smoothing/image.smoothing.worker-expected.txt:
• web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.alpha-expected.txt:
• web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.alpha.worker-expected.txt:
• web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.basic-expected.txt:
• web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.basic.worker-expected.txt:
• web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.transparent.1-expected.txt:
• web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.transparent.1.worker-expected.txt:
• web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.transparent.2-expected.txt:
• web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.transparent.2.worker-expected.txt:
• web-platform-tests/offscreen-canvas/the-offscreen-canvas/initial.reset.pattern-expected.txt:
• web-platform-tests/offscreen-canvas/the-offscreen-canvas/initial.reset.pattern.worker-expected.txt:

Source/WebCore:

No new tests. Covered by existing tests.

• bindings/js/CallTracerTypes.h:
• html/canvas/CanvasDrawImage.idl:
• html/canvas/CanvasFillStrokeStyles.idl:
• html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::size):
(WebCore::CanvasRenderingContext2DBase::drawImage):

• html/canvas/CanvasRenderingContext2DBase.h:
• inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::indexForData):
(WebCore::InspectorCanvas::buildAction):

• inspector/InspectorCanvas.h:

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.globalAlpha.canvas-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.globalAlpha.canvas.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.globalAlpha.canvascopy-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.globalAlpha.canvascopy.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.globalAlpha.canvaspattern-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.globalAlpha.canvaspattern.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.copy-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.copy.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.destination-atop-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.destination-atop.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.destination-in-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.destination-in.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.source-in-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.source-in.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.source-out-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.source-out.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/conformance-requirements/2d.voidreturn-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/conformance-requirements/2d.voidreturn.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.canvas-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.canvas.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.self.1-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.self.1.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.self.2-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.self.2.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.zerocanvas-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.zerocanvas.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.canvas-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.canvas.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.nocontext-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.nocontext.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.zerocanvas-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.zerocanvas.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.modify.canvas1-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.modify.canvas1.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.modify.canvas2-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.modify.canvas2.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.paint.orientation.canvas-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.paint.orientation.canvas.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.case-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.case.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.null-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.null.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.nullsuffix-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.nullsuffix.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.undefined-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.undefined.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.unrecognised-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.unrecognised.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.unrecognisednull-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.unrecognisednull.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/image-smoothing/image.smoothing-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/image-smoothing/image.smoothing.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.alpha-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.alpha.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.basic-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.basic.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.transparent.1-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.transparent.1.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.transparent.2-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.transparent.2.worker-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/the-offscreen-canvas/initial.reset.pattern-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/the-offscreen-canvas/initial.reset.pattern.worker-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/bindings/js/CallTracerTypes.h (modified) (2 diffs)
• Source/WebCore/html/OffscreenCanvas.h (modified) (2 diffs)
• Source/WebCore/html/canvas/CanvasDrawImage.idl (modified) (1 diff)
• Source/WebCore/html/canvas/CanvasFillStrokeStyles.idl (modified) (1 diff)
• Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp (modified) (2 diffs)
• Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h (modified) (3 diffs)
• Source/WebCore/inspector/InspectorCanvas.cpp (modified) (2 diffs)
• Source/WebCore/inspector/InspectorCanvas.h (modified) (2 diffs)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2019-11-25  Zan Dobersek  <zdobersek@igalia.com>
+
+        Support OffscreenCanvas as a CanvasImageSource type in CanvasDrawImage, CanvasFillStrokeStyles
+        https://bugs.webkit.org/show_bug.cgi?id=182921
+
+        Reviewed by Antti Koivisto.
+
+        * web-platform-tests/offscreen-canvas/compositing/2d.composite.globalAlpha.canvas-expected.txt:
+        * web-platform-tests/offscreen-canvas/compositing/2d.composite.globalAlpha.canvas.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/compositing/2d.composite.globalAlpha.canvascopy-expected.txt:
+        * web-platform-tests/offscreen-canvas/compositing/2d.composite.globalAlpha.canvascopy.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/compositing/2d.composite.globalAlpha.canvaspattern-expected.txt:
+        * web-platform-tests/offscreen-canvas/compositing/2d.composite.globalAlpha.canvaspattern.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.copy-expected.txt:
+        * web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.copy.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.destination-atop-expected.txt:
+        * web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.destination-atop.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.destination-in-expected.txt:
+        * web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.destination-in.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.source-in-expected.txt:
+        * web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.source-in.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.source-out-expected.txt:
+        * web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.source-out.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/conformance-requirements/2d.voidreturn-expected.txt:
+        * web-platform-tests/offscreen-canvas/conformance-requirements/2d.voidreturn.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/convert-to-blob/offscreencanvas.convert.to.blob.w-expected.txt:
+        * web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.canvas-expected.txt:
+        * web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.canvas.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.self.1-expected.txt:
+        * web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.self.1.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.self.2-expected.txt:
+        * web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.self.2.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.zerocanvas-expected.txt:
+        * web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.zerocanvas.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.canvas-expected.txt:
+        * web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.canvas.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.nocontext-expected.txt:
+        * web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.nocontext.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.zerocanvas-expected.txt:
+        * web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.zerocanvas.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.modify.canvas1-expected.txt:
+        * web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.modify.canvas1.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.modify.canvas2-expected.txt:
+        * web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.modify.canvas2.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.paint.orientation.canvas-expected.txt:
+        * web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.paint.orientation.canvas.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.case-expected.txt:
+        * web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.case.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.null-expected.txt:
+        * web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.null.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.nullsuffix-expected.txt:
+        * web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.nullsuffix.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.undefined-expected.txt:
+        * web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.undefined.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.unrecognised-expected.txt:
+        * web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.unrecognised.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.unrecognisednull-expected.txt:
+        * web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.unrecognisednull.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/image-smoothing/image.smoothing-expected.txt:
+        * web-platform-tests/offscreen-canvas/image-smoothing/image.smoothing.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.alpha-expected.txt:
+        * web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.alpha.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.basic-expected.txt:
+        * web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.basic.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.transparent.1-expected.txt:
+        * web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.transparent.1.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.transparent.2-expected.txt:
+        * web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.transparent.2.worker-expected.txt:
+        * web-platform-tests/offscreen-canvas/the-offscreen-canvas/initial.reset.pattern-expected.txt:
+        * web-platform-tests/offscreen-canvas/the-offscreen-canvas/initial.reset.pattern.worker-expected.txt:
+
 2019-11-25  Zan Dobersek  <zdobersek@igalia.com>  and  Chris Lord <clord@igalia.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.globalAlpha.canvas-expected.txt

@@ -2 +2 @@
 
 
-FAIL OffscreenCanvas test: 2d.composite.globalAlpha.canvas Type error
+PASS OffscreenCanvas test: 2d.composite.globalAlpha.canvas 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.globalAlpha.canvas.worker-expected.txt

@@ -1 +1 @@
 
-FAIL 2d Type error
+PASS 2d 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.globalAlpha.canvascopy-expected.txt

@@ -2 +2 @@
 
 
-FAIL OffscreenCanvas test: 2d.composite.globalAlpha.canvascopy Type error
+FAIL OffscreenCanvas test: 2d.composite.globalAlpha.canvascopy assert_approx_equals: Red channel of the pixel at (50, 25) expected 0 +/- 2 but got 125
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.globalAlpha.canvascopy.worker-expected.txt

@@ -1 +1 @@
 
-FAIL 2d Type error
+FAIL 2d assert_approx_equals: Red channel of the pixel at (50, 25) expected 0 +/- 2 but got 125
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.globalAlpha.canvaspattern-expected.txt

@@ -2 +2 @@
 
 
-FAIL OffscreenCanvas test: 2d.composite.globalAlpha.canvaspattern Type error
+PASS OffscreenCanvas test: 2d.composite.globalAlpha.canvaspattern 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.globalAlpha.canvaspattern.worker-expected.txt

@@ -1 +1 @@
 
-FAIL 2d Type error
+PASS 2d 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.copy-expected.txt

@@ -4 +4 @@
 
 
-FAIL drawImage() of a canvas with no context draws pixels as (0,0,0,0), and does not leave the pixels unchanged. Type error
+PASS drawImage() of a canvas with no context draws pixels as (0,0,0,0), and does not leave the pixels unchanged. 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.copy.worker-expected.txt

@@ -1 +1 @@
 
-FAIL drawImage() of a canvas with no context draws pixels as (0,0,0,0), and does not leave the pixels unchanged. Type error
+PASS drawImage() of a canvas with no context draws pixels as (0,0,0,0), and does not leave the pixels unchanged. 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.destination-atop-expected.txt

@@ -4 +4 @@
 
 
-FAIL drawImage() of a canvas with no context draws pixels as (0,0,0,0), and does not leave the pixels unchanged. Type error
+PASS drawImage() of a canvas with no context draws pixels as (0,0,0,0), and does not leave the pixels unchanged. 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.destination-atop.worker-expected.txt

@@ -1 +1 @@
 
-FAIL drawImage() of a canvas with no context draws pixels as (0,0,0,0), and does not leave the pixels unchanged. Type error
+PASS drawImage() of a canvas with no context draws pixels as (0,0,0,0), and does not leave the pixels unchanged. 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.destination-in-expected.txt

@@ -4 +4 @@
 
 
-FAIL drawImage() of a canvas with no context draws pixels as (0,0,0,0), and does not leave the pixels unchanged. Type error
+PASS drawImage() of a canvas with no context draws pixels as (0,0,0,0), and does not leave the pixels unchanged. 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.destination-in.worker-expected.txt

@@ -1 +1 @@
 
-FAIL drawImage() of a canvas with no context draws pixels as (0,0,0,0), and does not leave the pixels unchanged. Type error
+PASS drawImage() of a canvas with no context draws pixels as (0,0,0,0), and does not leave the pixels unchanged. 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.source-in-expected.txt

@@ -4 +4 @@
 
 
-FAIL drawImage() of a canvas with no context draws pixels as (0,0,0,0), and does not leave the pixels unchanged. Type error
+PASS drawImage() of a canvas with no context draws pixels as (0,0,0,0), and does not leave the pixels unchanged. 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.source-in.worker-expected.txt

@@ -1 +1 @@
 
-FAIL drawImage() of a canvas with no context draws pixels as (0,0,0,0), and does not leave the pixels unchanged. Type error
+PASS drawImage() of a canvas with no context draws pixels as (0,0,0,0), and does not leave the pixels unchanged. 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.source-out-expected.txt

@@ -4 +4 @@
 
 
-FAIL drawImage() of a canvas with no context draws pixels as (0,0,0,0), and does not leave the pixels unchanged. Type error
+PASS drawImage() of a canvas with no context draws pixels as (0,0,0,0), and does not leave the pixels unchanged. 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/compositing/2d.composite.uncovered.nocontext.source-out.worker-expected.txt

@@ -1 +1 @@
 
-FAIL drawImage() of a canvas with no context draws pixels as (0,0,0,0), and does not leave the pixels unchanged. Type error
+PASS drawImage() of a canvas with no context draws pixels as (0,0,0,0), and does not leave the pixels unchanged. 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/conformance-requirements/2d.voidreturn-expected.txt

@@ -4 +4 @@
 
 
-FAIL void methods return undefined Type error
+PASS void methods return undefined 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/conformance-requirements/2d.voidreturn.worker-expected.txt

@@ -1 +1 @@
 
-FAIL void methods return undefined Type error
+PASS void methods return undefined 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.canvas-expected.txt

@@ -2 +2 @@
 
 
-FAIL OffscreenCanvas test: 2d.drawImage.canvas Type error
+PASS OffscreenCanvas test: 2d.drawImage.canvas 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.canvas.worker-expected.txt

@@ -1 +1 @@
 
-FAIL 2d Type error
+PASS 2d 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.self.1-expected.txt

@@ -2 +2 @@
 
 
-FAIL OffscreenCanvas test: 2d.drawImage.self.1 Type error
+PASS OffscreenCanvas test: 2d.drawImage.self.1 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.self.1.worker-expected.txt

@@ -1 +1 @@
 
-FAIL 2d Type error
+PASS 2d 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.self.2-expected.txt

@@ -2 +2 @@
 
 
-FAIL OffscreenCanvas test: 2d.drawImage.self.2 Type error
+PASS OffscreenCanvas test: 2d.drawImage.self.2 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.self.2.worker-expected.txt

@@ -1 +1 @@
 
-FAIL 2d Type error
+PASS 2d 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.zerocanvas-expected.txt

@@ -2 +2 @@
 
 
-FAIL OffscreenCanvas test: 2d.drawImage.zerocanvas assert_throws: function "function () { ctx.drawImage(offscreenCanvas2, 0, 0); }" threw object "TypeError: Type error" that is not a DOMException INVALID_STATE_ERR: property "code" is equal to undefined, expected 11
+PASS OffscreenCanvas test: 2d.drawImage.zerocanvas 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/drawing-images-to-the-canvas/2d.drawImage.zerocanvas.worker-expected.txt

@@ -1 +1 @@
 
-FAIL 2d assert_throws: function "function () { ctx.drawImage(offscreenCanvas2, 0, 0); }" threw object "TypeError: Type error" that is not a DOMException INVALID_STATE_ERR: property "code" is equal to undefined, expected 11
+PASS 2d 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.canvas-expected.txt

@@ -2 +2 @@
 
 
-FAIL OffscreenCanvas test: 2d.pattern.basic.canvas Type error
+PASS OffscreenCanvas test: 2d.pattern.basic.canvas 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.canvas.worker-expected.txt

@@ -1 +1 @@
 
-FAIL 2d Type error
+PASS 2d 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.nocontext-expected.txt

@@ -2 +2 @@
 
 
-FAIL OffscreenCanvas test: 2d.pattern.basic.nocontext Type error
+PASS OffscreenCanvas test: 2d.pattern.basic.nocontext 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.nocontext.worker-expected.txt

@@ -1 +1 @@
 
-FAIL 2d Type error
+PASS 2d 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.zerocanvas-expected.txt

@@ -2 +2 @@
 
 
-FAIL OffscreenCanvas test: 2d.pattern.basic.zerocanvas assert_throws: function "function () { ctx.createPattern(offscreenCanvas, 'repeat'); }" threw object "TypeError: Type error" that is not a DOMException INVALID_STATE_ERR: property "code" is equal to undefined, expected 11
+PASS OffscreenCanvas test: 2d.pattern.basic.zerocanvas 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.zerocanvas.worker-expected.txt

@@ -1 +1 @@
 
-FAIL 2d assert_throws: function "function () { ctx.createPattern(offscreenCanvas, 'repeat'); }" threw object "TypeError: Type error" that is not a DOMException INVALID_STATE_ERR: property "code" is equal to undefined, expected 11
+PASS 2d 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.modify.canvas1-expected.txt

@@ -2 +2 @@
 
 
-FAIL OffscreenCanvas test: 2d.pattern.modify.canvas1 Type error
+PASS OffscreenCanvas test: 2d.pattern.modify.canvas1 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.modify.canvas1.worker-expected.txt

@@ -1 +1 @@
 
-FAIL 2d Type error
+PASS 2d 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.modify.canvas2-expected.txt

@@ -2 +2 @@
 
 
-FAIL OffscreenCanvas test: 2d.pattern.modify.canvas2 Type error
+PASS OffscreenCanvas test: 2d.pattern.modify.canvas2 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.modify.canvas2.worker-expected.txt

@@ -1 +1 @@
 
-FAIL 2d Type error
+PASS 2d 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.paint.orientation.canvas-expected.txt

@@ -4 +4 @@
 
 
-FAIL Canvas patterns do not get flipped when painted Type error
+PASS Canvas patterns do not get flipped when painted 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.paint.orientation.canvas.worker-expected.txt

@@ -1 +1 @@
 
-FAIL Canvas patterns do not get flipped when painted Type error
+PASS Canvas patterns do not get flipped when painted 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.case-expected.txt

@@ -2 +2 @@
 
 
-FAIL OffscreenCanvas test: 2d.pattern.repeat.case assert_throws: function "function () { ctx.createPattern(offscreenCanvas, "Repeat"); }" threw object "TypeError: Type error" that is not a DOMException SYNTAX_ERR: property "code" is equal to undefined, expected 12
+PASS OffscreenCanvas test: 2d.pattern.repeat.case 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.case.worker-expected.txt

@@ -1 +1 @@
 
-FAIL 2d assert_throws: function "function () { ctx.createPattern(offscreenCanvas, "Repeat"); }" threw object "TypeError: Type error" that is not a DOMException SYNTAX_ERR: property "code" is equal to undefined, expected 12
+PASS 2d 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.null-expected.txt

@@ -2 +2 @@
 
 
-FAIL OffscreenCanvas test: 2d.pattern.repeat.null Type error
+PASS OffscreenCanvas test: 2d.pattern.repeat.null 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.null.worker-expected.txt

@@ -1 +1 @@
 
-FAIL 2d Type error
+PASS 2d 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.nullsuffix-expected.txt

@@ -2 +2 @@
 
 
-FAIL OffscreenCanvas test: 2d.pattern.repeat.nullsuffix assert_throws: function "function () { ctx.createPattern(offscreenCanvas, "repeat\0"); }" threw object "TypeError: Type error" that is not a DOMException SYNTAX_ERR: property "code" is equal to undefined, expected 12
+PASS OffscreenCanvas test: 2d.pattern.repeat.nullsuffix 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.nullsuffix.worker-expected.txt

@@ -1 +1 @@
 
-FAIL 2d assert_throws: function "function () { ctx.createPattern(offscreenCanvas, "repeat\0"); }" threw object "TypeError: Type error" that is not a DOMException SYNTAX_ERR: property "code" is equal to undefined, expected 12
+PASS 2d 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.undefined-expected.txt

@@ -2 +2 @@
 
 
-FAIL OffscreenCanvas test: 2d.pattern.repeat.undefined assert_throws: function "function () { ctx.createPattern(offscreenCanvas, undefined); }" threw object "TypeError: Type error" that is not a DOMException SYNTAX_ERR: property "code" is equal to undefined, expected 12
+PASS OffscreenCanvas test: 2d.pattern.repeat.undefined 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.undefined.worker-expected.txt

@@ -1 +1 @@
 
-FAIL 2d assert_throws: function "function () { ctx.createPattern(offscreenCanvas, undefined); }" threw object "TypeError: Type error" that is not a DOMException SYNTAX_ERR: property "code" is equal to undefined, expected 12
+PASS 2d 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.unrecognised-expected.txt

@@ -2 +2 @@
 
 
-FAIL OffscreenCanvas test: 2d.pattern.repeat.unrecognised assert_throws: function "function () { ctx.createPattern(offscreenCanvas, "invalid"); }" threw object "TypeError: Type error" that is not a DOMException SYNTAX_ERR: property "code" is equal to undefined, expected 12
+PASS OffscreenCanvas test: 2d.pattern.repeat.unrecognised 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.unrecognised.worker-expected.txt

@@ -1 +1 @@
 
-FAIL 2d assert_throws: function "function () { ctx.createPattern(offscreenCanvas, "invalid"); }" threw object "TypeError: Type error" that is not a DOMException SYNTAX_ERR: property "code" is equal to undefined, expected 12
+PASS 2d 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.unrecognisednull-expected.txt

@@ -2 +2 @@
 
 
-FAIL OffscreenCanvas test: 2d.pattern.repeat.unrecognisednull assert_throws: function "function () { ctx.createPattern(offscreenCanvas, "null"); }" threw object "TypeError: Type error" that is not a DOMException SYNTAX_ERR: property "code" is equal to undefined, expected 12
+PASS OffscreenCanvas test: 2d.pattern.repeat.unrecognisednull 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.unrecognisednull.worker-expected.txt

@@ -1 +1 @@
 
-FAIL 2d assert_throws: function "function () { ctx.createPattern(offscreenCanvas, "null"); }" threw object "TypeError: Type error" that is not a DOMException SYNTAX_ERR: property "code" is equal to undefined, expected 12
+PASS 2d 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/image-smoothing/image.smoothing-expected.txt

@@ -2 +2 @@
 PASS When the context is created, imageSmoothingEnabled must be set to true. 
 PASS On getting imageSmoothingEnabled, the user agent must return the last value it was set to. 
-FAIL Test that image smoothing is actually on by default. Type error
-FAIL Test that image smoothing works when imageSmoothingEnabled is set to true Type error
-FAIL Test that imageSmoothingEnabled = false (nearest-neighbor interpolation) works with drawImage(). Type error
-FAIL Test that imageSmoothingEnabled = false (nearest-neighbor interpolation) works with fillRect and createPattern(). Type error
-FAIL Test that imageSmoothingEnabled = false (nearest-neighbor interpolation) works with fill() and createPattern(). Type error
-FAIL Test that imageSmoothingEnabled = false (nearest-neighbor interpolation) works with stroke() and createPattern(). Type error
-FAIL Test that imageSmoothingEnabled = false (nearest-neighbor interpolation) still works after repaints. Type error
+PASS Test that image smoothing is actually on by default. 
+PASS Test that image smoothing works when imageSmoothingEnabled is set to true 
+PASS Test that imageSmoothingEnabled = false (nearest-neighbor interpolation) works with drawImage(). 
+FAIL Test that imageSmoothingEnabled = false (nearest-neighbor interpolation) works with fillRect and createPattern(). assert_array_equals: property 0, expected 0 but got 176
+FAIL Test that imageSmoothingEnabled = false (nearest-neighbor interpolation) works with fill() and createPattern(). assert_array_equals: property 0, expected 0 but got 176
+FAIL Test that imageSmoothingEnabled = false (nearest-neighbor interpolation) works with stroke() and createPattern(). assert_array_equals: property 0, expected 0 but got 176
+PASS Test that imageSmoothingEnabled = false (nearest-neighbor interpolation) still works after repaints. 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/image-smoothing/image.smoothing.worker-expected.txt

@@ -2 +2 @@
 PASS When the context is created, imageSmoothingEnabled must be set to true. 
 PASS On getting imageSmoothingEnabled, the user agent must return the last value it was set to. 
-FAIL Test that image smoothing is actually on by default. Type error
-FAIL Test that image smoothing works when imageSmoothingEnabled is set to true Type error
-FAIL Test that imageSmoothingEnabled = false (nearest-neighbor interpolation) works with drawImage(). Type error
-FAIL Test that imageSmoothingEnabled = false (nearest-neighbor interpolation) works with fillRect and createPattern(). Type error
-FAIL Test that imageSmoothingEnabled = false (nearest-neighbor interpolation) works with fill() and createPattern(). Type error
-FAIL Test that imageSmoothingEnabled = false (nearest-neighbor interpolation) works with stroke() and createPattern(). Type error
-FAIL Test that imageSmoothingEnabled = false (nearest-neighbor interpolation) still works after repaints. Type error
+PASS Test that image smoothing is actually on by default. 
+PASS Test that image smoothing works when imageSmoothingEnabled is set to true 
+PASS Test that imageSmoothingEnabled = false (nearest-neighbor interpolation) works with drawImage(). 
+FAIL Test that imageSmoothingEnabled = false (nearest-neighbor interpolation) works with fillRect and createPattern(). assert_array_equals: property 0, expected 0 but got 176
+FAIL Test that imageSmoothingEnabled = false (nearest-neighbor interpolation) works with fill() and createPattern(). assert_array_equals: property 0, expected 0 but got 176
+FAIL Test that imageSmoothingEnabled = false (nearest-neighbor interpolation) works with stroke() and createPattern(). assert_array_equals: property 0, expected 0 but got 176
+PASS Test that imageSmoothingEnabled = false (nearest-neighbor interpolation) still works after repaints. 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.alpha-expected.txt

@@ -4 +4 @@
 
 
-FAIL Shadows are drawn correctly for partially-transparent canvases Type error
+PASS Shadows are drawn correctly for partially-transparent canvases 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.alpha.worker-expected.txt

@@ -1 +1 @@
 
-FAIL Shadows are drawn correctly for partially-transparent canvases Type error
+PASS Shadows are drawn correctly for partially-transparent canvases 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.basic-expected.txt

@@ -4 +4 @@
 
 
-FAIL Shadows are drawn for canvases Type error
+PASS Shadows are drawn for canvases 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.basic.worker-expected.txt

@@ -1 +1 @@
 
-FAIL Shadows are drawn for canvases Type error
+PASS Shadows are drawn for canvases 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.transparent.1-expected.txt

@@ -4 +4 @@
 
 
-FAIL Shadows are not drawn for transparent canvases Type error
+PASS Shadows are not drawn for transparent canvases 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.transparent.1.worker-expected.txt

@@ -1 +1 @@
 
-FAIL Shadows are not drawn for transparent canvases Type error
+PASS Shadows are not drawn for transparent canvases 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.transparent.2-expected.txt

@@ -4 +4 @@
 
 
-FAIL Shadows are not drawn for transparent parts of canvases Type error
+PASS Shadows are not drawn for transparent parts of canvases 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/shadows/2d.shadow.canvas.transparent.2.worker-expected.txt

@@ -1 +1 @@
 
-FAIL Shadows are not drawn for transparent parts of canvases Type error
+PASS Shadows are not drawn for transparent parts of canvases 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/the-offscreen-canvas/initial.reset.pattern-expected.txt

@@ -4 +4 @@
 
 
-FAIL Resetting the canvas state does not invalidate any existing patterns Type error
+PASS Resetting the canvas state does not invalidate any existing patterns 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/offscreen-canvas/the-offscreen-canvas/initial.reset.pattern.worker-expected.txt

@@ -1 +1 @@
 
-FAIL Resetting the canvas state does not invalidate any existing patterns Type error
+PASS Resetting the canvas state does not invalidate any existing patterns 
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-11-25  Zan Dobersek  <zdobersek@igalia.com>
+
+        Support OffscreenCanvas as a CanvasImageSource type in CanvasDrawImage, CanvasFillStrokeStyles
+        https://bugs.webkit.org/show_bug.cgi?id=182921
+
+        Reviewed by Antti Koivisto.
+
+        No new tests. Covered by existing tests.
+
+        * bindings/js/CallTracerTypes.h:
+        * html/canvas/CanvasDrawImage.idl:
+        * html/canvas/CanvasFillStrokeStyles.idl:
+        * html/canvas/CanvasRenderingContext2DBase.cpp:
+        (WebCore::size):
+        (WebCore::CanvasRenderingContext2DBase::drawImage):
+        * html/canvas/CanvasRenderingContext2DBase.h:
+        * inspector/InspectorCanvas.cpp:
+        (WebCore::InspectorCanvas::indexForData):
+        (WebCore::InspectorCanvas::buildAction):
+        * inspector/InspectorCanvas.h:
+
 2019-11-25  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/bindings/js/CallTracerTypes.h

@@ -35 +35 @@
 #include "HTMLVideoElement.h"
 #include "ImageData.h"
+#if ENABLE(OFFSCREEN_CANVAS)
+#include "OffscreenCanvas.h"
+#endif
 #include "Path2D.h"
 #include "TypedOMCSSImageValue.h"
@@ -118 +121 @@
 #endif
     RefPtr<ImageData>,
+#if ENABLE(OFFSCREEN_CANVAS)
+    RefPtr<OffscreenCanvas>,
+#endif
     RefPtr<Int32Array>,
     RefPtr<Uint32Array>,

trunk/Source/WebCore/html/OffscreenCanvas.h

@@ -85 +85 @@
 
     Image* copiedImage() const final { return nullptr; }
+    bool hasCreatedImageBuffer() const final { return m_hasCreatedImageBuffer; }
 
     CSSValuePool& cssValuePool();
@@ -109 +110 @@
     void setSize(const IntSize&) final;
     void createImageBuffer() const final;
-    bool hasCreatedImageBuffer() const final { return m_hasCreatedImageBuffer; }
     void reset();
 

trunk/Source/WebCore/html/canvas/CanvasDrawImage.idl

@@ -24 +24 @@
  */
 
-// FIXME: This should include SVGImageElement and ImageBitmap.
-#if defined(ENABLE_VIDEO) && ENABLE_VIDEO && defined(ENABLE_CSS_TYPED_OM) && ENABLE_CSS_TYPED_OM
-typedef (HTMLImageElement or HTMLVideoElement or HTMLCanvasElement or ImageBitmap or TypedOMCSSImageValue) CanvasImageSource;
-#elif defined(ENABLE_VIDEO) && ENABLE_VIDEO
-typedef (HTMLImageElement or HTMLVideoElement or HTMLCanvasElement or ImageBitmap) CanvasImageSource;
-#else
-typedef (HTMLImageElement or HTMLCanvasElement or ImageBitmap) CanvasImageSource;
+// FIXME: This should include SVGImageElement.
+typedef (HTMLImageElement or HTMLCanvasElement or ImageBitmap
+#if defined(ENABLE_CSS_TYPED_OM) && ENABLE_CSS_TYPED_OM
+    or TypedOMCSSImageValue
 #endif
+#if defined(ENABLE_OFFSCREEN_CANVAS) && ENABLE_OFFSCREEN_CANVAS
+    or OffscreenCanvas
+#endif
+#if defined(ENABLE_VIDEO) && ENABLE_VIDEO
+    or HTMLVideoElement
+#endif
+) CanvasImageSource;
 
 [

trunk/Source/WebCore/html/canvas/CanvasFillStrokeStyles.idl

@@ -24 +24 @@
  */
 
-// FIXME: This should include SVGImageElement and ImageBitmap.
-#if defined(ENABLE_VIDEO) && ENABLE_VIDEO && defined(ENABLE_CSS_TYPED_OM) && ENABLE_CSS_TYPED_OM
-typedef (HTMLImageElement or HTMLVideoElement or HTMLCanvasElement or ImageBitmap or TypedOMCSSImageValue) CanvasImageSource;
-#elif defined(ENABLE_VIDEO) && ENABLE_VIDEO
-typedef (HTMLImageElement or HTMLVideoElement or HTMLCanvasElement or ImageBitmap) CanvasImageSource;
-#else
-typedef (HTMLImageElement or HTMLCanvasElement or ImageBitmap) CanvasImageSource;
+// FIXME: This should include SVGImageElement.
+typedef (HTMLImageElement or HTMLCanvasElement or ImageBitmap
+#if defined(ENABLE_CSS_TYPED_OM) && ENABLE_CSS_TYPED_OM
+    or TypedOMCSSImageValue
 #endif
+#if defined(ENABLE_OFFSCREEN_CANVAS) && ENABLE_OFFSCREEN_CANVAS
+    or OffscreenCanvas
+#endif
+#if defined(ENABLE_VIDEO) && ENABLE_VIDEO
+    or HTMLVideoElement
+#endif
+) CanvasImageSource;
 
 [

trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp

@@ -1408 +1408 @@
 }
 
-static inline FloatSize size(HTMLCanvasElement& canvasElement)
-{
-    return canvasElement.size();
+static inline FloatSize size(CanvasBase& canvas)
+{
+    return canvas.size();
 }
 
@@ -1596 +1596 @@
 }
 
-ExceptionOr<void> CanvasRenderingContext2DBase::drawImage(HTMLCanvasElement& sourceCanvas, const FloatRect& srcRect, const FloatRect& dstRect)
+ExceptionOr<void> CanvasRenderingContext2DBase::drawImage(CanvasBase& sourceCanvas, const FloatRect& srcRect, const FloatRect& dstRect)
 {
     FloatRect srcCanvasRect = FloatRect(FloatPoint(), sourceCanvas.size());

trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h

@@ -63 +63 @@
 class ImageBitmap;
 class ImageData;
+class OffscreenCanvas;
 class Path2D;
 class RenderStyle;
@@ -70 +71 @@
 struct DOMMatrix2DInit;
 
-#if ENABLE(VIDEO) && ENABLE(CSS_TYPED_OM)
-using CanvasImageSource = Variant<RefPtr<HTMLImageElement>, RefPtr<HTMLVideoElement>, RefPtr<HTMLCanvasElement>, RefPtr<ImageBitmap>, RefPtr<TypedOMCSSImageValue>>;
-#elif ENABLE(VIDEO)
-using CanvasImageSource = Variant<RefPtr<HTMLImageElement>, RefPtr<HTMLVideoElement>, RefPtr<HTMLCanvasElement>, RefPtr<ImageBitmap>>;
-#else
-using CanvasImageSource = Variant<RefPtr<HTMLImageElement>, RefPtr<HTMLCanvasElement>, RefPtr<ImageBitmap>>;
-#endif
+using CanvasImageSource = Variant<RefPtr<HTMLImageElement>, RefPtr<HTMLCanvasElement>, RefPtr<ImageBitmap>
+#if ENABLE(CSS_TYPED_OM)
+    , RefPtr<TypedOMCSSImageValue>
+#endif
+#if ENABLE(OFFSCREEN_CANVAS)
+    , RefPtr<OffscreenCanvas>
+#endif
+#if ENABLE(VIDEO)
+    , RefPtr<HTMLVideoElement>
+#endif
+    >;
 
 class CanvasRenderingContext2DBase : public CanvasRenderingContext, public CanvasPath {
@@ -334 +339 @@
     ExceptionOr<void> drawImage(HTMLImageElement&, const FloatRect& srcRect, const FloatRect& dstRect);
     ExceptionOr<void> drawImage(HTMLImageElement&, const FloatRect& srcRect, const FloatRect& dstRect, const CompositeOperator&, const BlendMode&);
-    ExceptionOr<void> drawImage(HTMLCanvasElement&, const FloatRect& srcRect, const FloatRect& dstRect);
+    ExceptionOr<void> drawImage(CanvasBase&, const FloatRect& srcRect, const FloatRect& dstRect);
     ExceptionOr<void> drawImage(Document&, CachedImage*, const RenderObject*, const FloatRect& imageRect, const FloatRect& srcRect, const FloatRect& dstRect, const CompositeOperator&, const BlendMode&);
 #if ENABLE(VIDEO)

trunk/Source/WebCore/inspector/InspectorCanvas.cpp

@@ -758 +758 @@
             item = WTFMove(array);
         },
+#if ENABLE(OFFSCREEN_CANVAS)
+        [&] (const RefPtr<OffscreenCanvas> offscreenCanvas) {
+            String dataURL = "data:,"_s;
+
+            if (offscreenCanvas->originClean() && offscreenCanvas->hasCreatedImageBuffer()) {
+                if (auto *buffer = offscreenCanvas->buffer())
+                    dataURL = buffer->toDataURL("image/png");
+            }
+
+            index = indexForData(dataURL);
+        },
+#endif
         [&] (const String& value) { item = JSON::Value::create(value); }
     );
@@ -1034 +1046 @@
                     addParameter(indexForData(value), RecordingSwizzleTypes::Image);
             },
+#if ENABLE(OFFSCREEN_CANVAS)
+            [&] (const RefPtr<OffscreenCanvas>& value) {
+                if (value)
+                    addParameter(indexForData(value), RecordingSwizzleTypes::Image);
+            },
+#endif
 #if ENABLE(VIDEO)
             [&] (const RefPtr<HTMLVideoElement>& value) {

trunk/Source/WebCore/inspector/InspectorCanvas.h

@@ -52 +52 @@
 class ImageBitmap;
 class ImageData;
+#if ENABLE(OFFSCREEN_CANVAS)
+class OffscreenCanvas;
+#endif
 #if ENABLE(CSS_TYPED_OM)
 class TypedOMCSSImageValue;
@@ -130 +133 @@
 #endif
         Inspector::ScriptCallFrame,
+#if ENABLE(OFFSCREEN_CANVAS)
+        RefPtr<OffscreenCanvas>,
+#endif
         String
     >;