Changeset 252885 in webkit

Timestamp:

Nov 26, 2019 4:21:13 AM (4 years ago)

Author:

commit-queue@webkit.org

Message:

Attempting to enable more than one FuzzerAgent should result in an error
​https://bugs.webkit.org/show_bug.cgi?id=204607

Patch by Tuomas Karkkainen <​tuomas.webkit@apple.com> on 2019-11-26
Reviewed by Antti Koivisto.

• runtime/VM.cpp:
• runtime/VM.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/VM.cpp (modified) (1 diff)
• runtime/VM.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-11-26  Tuomas Karkkainen  <tuomas.webkit@apple.com>
+
+        Attempting to enable more than one FuzzerAgent should result in an error
+        https://bugs.webkit.org/show_bug.cgi?id=204607
+
+        Reviewed by Antti Koivisto.
+
+        * runtime/VM.cpp:
+        * runtime/VM.h:
+
 2019-11-26  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/JavaScriptCore/runtime/VM.cpp

@@ -462 +462 @@
     if (Options::useRandomizingFuzzerAgent())
         setFuzzerAgent(makeUnique<RandomizingFuzzerAgent>(*this));
-    else if (Options::useDoublePredictionFuzzerAgent())
+    if (Options::useDoublePredictionFuzzerAgent())
         setFuzzerAgent(makeUnique<DoublePredictionFuzzerAgent>(*this));
 

trunk/Source/JavaScriptCore/runtime/VM.h

@@ -304 +304 @@
     void setFuzzerAgent(std::unique_ptr<FuzzerAgent>&& fuzzerAgent)
     {
+        RELEASE_ASSERT_WITH_MESSAGE(!m_fuzzerAgent, "Only one FuzzerAgent can be specified at a time.");
         m_fuzzerAgent = WTFMove(fuzzerAgent);
     }