Changeset 252907 in webkit

Timestamp:

Nov 27, 2019 9:11:08 AM (4 years ago)

Author:

Antti Koivisto

Message:

[LFC][Render tree] PerformanceTests/Layout/line-layout-simple.html does not update properly with LFC enabled
​https://bugs.webkit.org/show_bug.cgi?id=204646

Reviewed by Zalan Bujtas.

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::invalidateLineLayoutPath):

Destroy LFC layout here, for now.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderBlockFlow.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-11-27  Antti Koivisto  <antti@apple.com>
+
+        [LFC][Render tree] PerformanceTests/Layout/line-layout-simple.html does not update properly with LFC enabled
+        https://bugs.webkit.org/show_bug.cgi?id=204646
+
+        Reviewed by Zalan Bujtas.
+
+        * rendering/RenderBlockFlow.cpp:
+        (WebCore::RenderBlockFlow::invalidateLineLayoutPath):
+
+        Destroy LFC layout here, for now. 
+
 2019-11-27  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/rendering/RenderBlockFlow.cpp

@@ -3628 +3628 @@
         return;
     case LineBoxesPath:
-    case LFCPath:
         ASSERT(!simpleLineLayout());
         setLineLayoutPath(UndeterminedPath);
         return;
+    case LFCPath: // FIXME: Not all clients of invalidateLineLayoutPath() actually need to wipe the layout.
     case SimpleLinesPath:
         // The simple line layout may have become invalid.