Changeset 252913 in webkit

Timestamp:

Nov 27, 2019 3:07:46 PM (4 years ago)

Author:

Manuel Rego Casasnovas

Message:

Using char* instead of String for StyleProperties::getShorthandValue()
​https://bugs.webkit.org/show_bug.cgi?id=204644

Reviewed by Darin Adler.

This is follow-up patch for r252901. We don't need to create a String object
just for the separator and can use char* instead.
This was suggested by Darin Adler in webkit.org/b/204508.

• css/StyleProperties.cpp:

(WebCore::StyleProperties::getShorthandValue const):

• css/StyleProperties.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/StyleProperties.cpp (modified) (1 diff)
• css/StyleProperties.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-11-27  Manuel Rego Casasnovas  <rego@igalia.com>
+
+        Using char* instead of String for StyleProperties::getShorthandValue()
+        https://bugs.webkit.org/show_bug.cgi?id=204644
+
+        Reviewed by Darin Adler.
+
+        This is follow-up patch for r252901. We don't need to create a String object
+        just for the separator and can use char* instead.
+        This was suggested by Darin Adler in webkit.org/b/204508.
+
+        * css/StyleProperties.cpp:
+        (WebCore::StyleProperties::getShorthandValue const):
+        * css/StyleProperties.h:
+
 2019-11-27  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/css/StyleProperties.cpp

@@ -656 +656 @@
 }
 
-String StyleProperties::getShorthandValue(const StylePropertyShorthand& shorthand, const String& separator) const
+String StyleProperties::getShorthandValue(const StylePropertyShorthand& shorthand, const char* separator) const
 {
     String commonValue;

trunk/Source/WebCore/css/StyleProperties.h

@@ -161 +161 @@
 private:
     String getGridShorthandValue(const StylePropertyShorthand&) const;
-    String getShorthandValue(const StylePropertyShorthand&, const String& separator = " ") const;
+    String getShorthandValue(const StylePropertyShorthand&, const char* separator = " ") const;
     String getCommonValue(const StylePropertyShorthand&) const;
     String getAlignmentShorthandValue(const StylePropertyShorthand&) const;