Changeset 252956 in webkit
- Timestamp:
- Nov 30, 2019 4:32:56 AM (4 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r252955 r252956 1 2019-11-30 youenn fablet <youenn@apple.com> 2 3 MockAudioSharedUnit should reset its last render time on start/stop/reconfigure 4 https://bugs.webkit.org/show_bug.cgi?id=204600 5 <rdar://problem/57438874> 6 7 Reviewed by Eric Carlson. 8 9 MockAudioSharedUnit was not resetting its last render time on stop/start/reconfigure. 10 If stopping for a long time and then restarting, the unit would flood the audio pipe with lots of data 11 and confuse the pipe. 12 Remove some member variables inherited from MockRealtimeAudioSource which are no longer needed. 13 14 Covered by imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html being no longer flaky. 15 16 * platform/mediastream/mac/MockAudioSharedUnit.h: 17 * platform/mediastream/mac/MockAudioSharedUnit.mm: 18 (WebCore::MockAudioSharedUnit::reconfigureAudioUnit): 19 (WebCore::MockAudioSharedUnit::startInternal): 20 1 21 2019-11-30 Philippe Normand <pnormand@igalia.com> 2 22 -
trunk/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.h
r252660 r252956 83 83 84 84 RunLoop::Timer<MockAudioSharedUnit> m_timer; 85 MonotonicTime m_startTime { MonotonicTime::nan() };86 85 MonotonicTime m_lastRenderTime { MonotonicTime::nan() }; 87 Seconds m_elapsedTime { 0_s };88 86 MonotonicTime m_delayUntil; 89 87 -
trunk/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm
r252681 r252956 129 129 130 130 m_timer.stop(); 131 m_ startTime = MonotonicTime::nan();131 m_lastRenderTime = MonotonicTime::nan(); 132 132 m_workQueue->dispatch([this] { 133 133 reconfigure(); 134 134 callOnMainThread([this] { 135 m_ startTime = MonotonicTime::now();135 m_lastRenderTime = MonotonicTime::now(); 136 136 m_timer.startRepeating(renderInterval()); 137 137 }); … … 144 144 m_hasAudioUnit = false; 145 145 m_timer.stop(); 146 m_ startTime = MonotonicTime::nan();146 m_lastRenderTime = MonotonicTime::nan(); 147 147 } 148 148 … … 155 155 m_hasAudioUnit = true; 156 156 157 m_ startTime = MonotonicTime::now();157 m_lastRenderTime = MonotonicTime::now(); 158 158 m_timer.startRepeating(renderInterval()); 159 159 return 0; … … 165 165 return; 166 166 m_timer.stop(); 167 m_ startTime = MonotonicTime::nan();167 m_lastRenderTime = MonotonicTime::nan(); 168 168 } 169 169
Note: See TracChangeset
for help on using the changeset viewer.