Changeset 252985 in webkit


Ignore:
Timestamp:
Dec 2, 2019 9:10:36 AM (4 years ago)
Author:
youenn@apple.com
Message:

Service Worker should correctly set its document first party for cookies URL
​https://bugs.webkit.org/show_bug.cgi?id=204742

Reviewed by Chris Dumez.

Source/WebCore:

Test: http/wpt/service-workers/third-party-cookie.html

  • workers/service/context/ServiceWorkerThreadProxy.cpp:

(WebCore::createPageForServiceWorker):
Set document first party cookie for URL to the top origin.

LayoutTests:

  • http/wpt/service-workers/resources/set-cookie.py: Added.
  • http/wpt/service-workers/resources/third-party-cookie-iframe.html: Added.
  • http/wpt/service-workers/resources/third-party-worker.js:
  • http/wpt/service-workers/third-party-cookie-expected.txt: Added.
  • http/wpt/service-workers/third-party-cookie.html: Added.
Location:
trunk
Files:
4 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r252983 r252985  
     12019-12-02  youenn fablet  <youenn@apple.com>
     2
     3        Service Worker should correctly set its document first party for cookies URL
     4        https://bugs.webkit.org/show_bug.cgi?id=204742
     5
     6        Reviewed by Chris Dumez.
     7
     8        * http/wpt/service-workers/resources/set-cookie.py: Added.
     9        * http/wpt/service-workers/resources/third-party-cookie-iframe.html: Added.
     10        * http/wpt/service-workers/resources/third-party-worker.js:
     11        * http/wpt/service-workers/third-party-cookie-expected.txt: Added.
     12        * http/wpt/service-workers/third-party-cookie.html: Added.
     13
    1142019-12-02  Simon Fraser  <simon.fraser@apple.com>
    215

  • trunk/LayoutTests/http/wpt/service-workers/resources/third-party-worker.js

    r231861 r252985  
    1717            var result = { cache : keys, db : db };
    1818            e.source.postMessage(JSON.stringify(result));
     19            return;
     20        }
     21        if (e.data === 'set-cookie') {
     22            await fetch("/WebKit/service-workers/resources/set-cookie.py?name=mycookie&path=%2F");
     23            e.source.postMessage('cookie-is-set');
    1924            return;
    2025        }

  • trunk/Source/WebCore/ChangeLog

    r252983 r252985  
     12019-12-02  youenn fablet  <youenn@apple.com>
     2
     3        Service Worker should correctly set its document first party for cookies URL
     4        https://bugs.webkit.org/show_bug.cgi?id=204742
     5
     6        Reviewed by Chris Dumez.
     7
     8        Test: http/wpt/service-workers/third-party-cookie.html
     9
     10        * workers/service/context/ServiceWorkerThreadProxy.cpp:
     11        (WebCore::createPageForServiceWorker):
     12        Set document first party cookie for URL to the top origin.
     13
    1142019-12-02  Simon Fraser  <simon.fraser@apple.com>
    215

  • trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp

    r252118 r252985  
    7070
    7171    document->setSiteForCookies(topOriginURL(origin));
    72     document->setFirstPartyForCookies(data.scriptURL);
     72    document->setFirstPartyForCookies(topOriginURL(origin));
    7373    document->setDomainForCachePartition(origin->domainForCachePartition());
    7474
Note: See TracChangeset for help on using the changeset viewer.