Changeset 252991 in webkit

Timestamp:

Dec 2, 2019 10:32:49 AM (4 years ago)

Author:

dbates@webkit.org

Message:

REGRESSION (r195080): prepare-ChangeLog does not emit function list for file paths that contain a space
​https://bugs.webkit.org/show_bug.cgi?id=204236

Reviewed by Brian Burg.

Revert the filename escape logic added in <​http://trac.webkit.org/changeset/195080> as it broke
function list generation in file paths that contain space characters. Function list generation
broke because the escaping was performed after line range dictionaries were built up keyed off
the unescaped file path. Subsequent code would try to query these dictionaries to build up the
changed function list using the escaped file path and never a match. The escaping logic was not
necessary to fix the originally reported bug. All that was needed was to use the three-argument
open() call that took a mode. So, remove the escape logic.

• Scripts/prepare-ChangeLog:

(actuallyGenerateFunctionLists):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/prepare-ChangeLog (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-12-02  Daniel Bates  <dabates@apple.com>
+
+        REGRESSION (r195080): prepare-ChangeLog does not emit function list for file paths that contain a space
+        https://bugs.webkit.org/show_bug.cgi?id=204236
+
+        Reviewed by Brian Burg.
+
+        Revert the filename escape logic added in <http://trac.webkit.org/changeset/195080> as it broke
+        function list generation in file paths that contain space characters. Function list generation
+        broke because the escaping was performed after line range dictionaries were built up keyed off
+        the unescaped file path. Subsequent code would try to query these dictionaries to build up the
+        changed function list using the escaped file path and never a match. The escaping logic was not
+        necessary to fix the originally reported bug. All that was needed was to use the three-argument
+        open() call that took a mode. So, remove the escape logic.
+
+        * Scripts/prepare-ChangeLog:
+        (actuallyGenerateFunctionLists):
+
 2019-11-30  Ross Kirsling  <ross.kirsling@sony.com>
 

trunk/Tools/Scripts/prepare-ChangeLog

@@ -346 +346 @@
     my %filesToExamine = map { $_ => 1 } (keys(%line_ranges_before_changed), keys(%line_ranges_after_changed));
     foreach my $file (keys %filesToExamine) {
-        # Escape whitespace in filenames rather than adding quotes, since many functions can open files
-        # and other code doesn't expect to see a trailing " character when sniffing a file extension.
-        chomp $file;
-        $file =~ s/ /\\ /g;
-
         my %saw_function;