Changeset 253000 in webkit

Timestamp:

Dec 2, 2019 11:22:21 AM (4 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Console: the saved result value is still shown after page reload
​https://bugs.webkit.org/show_bug.cgi?id=204532

Reviewed by Brian Burg.

Add additional plumbing to remove any .console-saved-variable elements whenever a new
session is created, as well as reset the base of the property path to this.

• UserInterface/Views/LogContentView.js:

(WI.LogContentView.prototype._sessionStarted):
(WI.LogContentView.prototype._logCleared):

• UserInterface/Views/ConsoleMessageView.js:

(WI.ConsoleMessageView.prototype.clearSavedVariableState): Added.
(WI.ConsoleMessageView.prototype.removeEventListeners): Deleted.

• UserInterface/Views/ObjectTreeView.js:

(WI.ObjectTreeView.prototype.resetPropertyPath): Added.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ConsoleMessageView.js (modified) (1 diff)
• UserInterface/Views/LogContentView.js (modified) (2 diffs)
• UserInterface/Views/ObjectTreeView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-12-02  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Console: the saved result value is still shown after page reload
+        https://bugs.webkit.org/show_bug.cgi?id=204532
+
+        Reviewed by Brian Burg.
+
+        Add additional plumbing to remove any `.console-saved-variable` elements whenever a new
+        session is created, as well as reset the base of the property path to `this`.
+
+        * UserInterface/Views/LogContentView.js:
+        (WI.LogContentView.prototype._sessionStarted):
+        (WI.LogContentView.prototype._logCleared):
+
+        * UserInterface/Views/ConsoleMessageView.js:
+        (WI.ConsoleMessageView.prototype.clearSavedVariableState): Added.
+        (WI.ConsoleMessageView.prototype.removeEventListeners): Deleted.
+
+        * UserInterface/Views/ObjectTreeView.js:
+        (WI.ObjectTreeView.prototype.resetPropertyPath): Added.
+
 2019-11-22  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js

@@ -244 +244 @@
     }
 
-    removeEventListeners()
-    {
+    clearSavedVariableState()
+    {
+        for (let node of this._messageBodyElement.querySelectorAll(".console-saved-variable"))
+            node.remove();
+
+        if (this._objectTree)
+            this._objectTree.resetPropertyPath();
+
         // FIXME: <https://webkit.org/b/196956> Web Inspector: use weak collections for holding event listeners
         WI.settings.consoleSavedResultAlias.removeEventListener(null, null, this);

trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js

@@ -399 +399 @@
         for (let messageElement of this._allMessageElements()) {
             if (messageElement.__messageView)
-                messageElement.__messageView.removeEventListeners();
+                messageElement.__messageView.clearSavedVariableState();
         }
 
@@ -837 +837 @@
         for (let messageElement of this._allMessageElements()) {
             if (messageElement.__messageView)
-                messageElement.__messageView.removeEventListeners();
+                messageElement.__messageView.clearSavedVariableState();
         }
 

trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js

@@ -322 +322 @@
     }
 
+    resetPropertyPath()
+    {
+        this._propertyPath.pathComponent = "this";
+    }
+
     // Protected