Changeset 253008 in webkit
- Timestamp:
- Dec 2, 2019 2:16:42 PM (4 years ago)
- Location:
- trunk
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/JSTests/ChangeLog
r252975 r253008 1 2019-12-02 Mark Lam <mark.lam@apple.com> 2 3 mozilla-tests.yaml/js1_5/Array/regress-101964.js is frequently failing on JSC EWS bots. 4 https://bugs.webkit.org/show_bug.cgi?id=200789 5 <rdar://problem/54361916> 6 7 Reviewed by Keith Miller. 8 9 The prevailing theory is that this test is being pre-empted and not getting the 10 CPU time it needs to complete. As a result, the wall clock time period for 11 running the test exceeds the expected time. This patch tests this theory by 12 changing the time measurement to use CPU time instead. 13 14 * mozilla/js1_5/Array/regress-101964.js: 15 1 16 2019-12-01 Caio Lima <ticaiolima@gmail.com> 2 17 -
trunk/JSTests/mozilla/js1_5/Array/regress-101964.js
r209596 r253008 47 47 status = inSection(1); 48 48 var arr = Array(BIG); 49 var start = new Date();49 var start = $vm.currentCPUTime(); 50 50 arr.length = LITTLE; 51 51 actual = elapsedTime(start); … … 63 63 function elapsedTime(startTime) 64 64 { 65 return new Date() - startTime;65 return $vm.currentCPUTime() - startTime; 66 66 } 67 67 -
trunk/Source/JavaScriptCore/ChangeLog
r253007 r253008 1 2019-12-02 Mark Lam <mark.lam@apple.com> 2 3 mozilla-tests.yaml/js1_5/Array/regress-101964.js is frequently failing on JSC EWS bots. 4 https://bugs.webkit.org/show_bug.cgi?id=200789 5 <rdar://problem/54361916> 6 7 Reviewed by Keith Miller. 8 9 * tools/JSDollarVM.cpp: 10 (JSC::functionCurrentCPUTime): 11 (JSC::JSDollarVM::finishCreation): 12 1 13 2019-12-02 Yusuke Suzuki <ysuzuki@apple.com> 2 14 -
trunk/Source/JavaScriptCore/tools/JSDollarVM.cpp
r252767 r253008 54 54 #include "WasmCapabilities.h" 55 55 #include <wtf/Atomics.h> 56 #include <wtf/CPUTime.h> 56 57 #include <wtf/DataLog.h> 57 58 #include <wtf/ProcessID.h> … … 2676 2677 } 2677 2678 2679 static EncodedJSValue JSC_HOST_CALL functionCurrentCPUTime(JSGlobalObject*, CallFrame*) 2680 { 2681 DollarVMAssertScope assertScope; 2682 return JSValue::encode(jsNumber(CPUTime::forCurrentThread().value())); 2683 } 2684 2678 2685 static EncodedJSValue JSC_HOST_CALL functionTotalGCTime(JSGlobalObject* globalObject, CallFrame*) 2679 2686 { … … 2833 2840 addFunction(vm, "deltaBetweenButterflies", functionDeltaBetweenButterflies, 2); 2834 2841 2842 addFunction(vm, "currentCPUTime", functionCurrentCPUTime, 0); 2835 2843 addFunction(vm, "totalGCTime", functionTotalGCTime, 0); 2836 2844
Note: See TracChangeset
for help on using the changeset viewer.