Changeset 253008 in webkit


Ignore:
Timestamp:
Dec 2, 2019 2:16:42 PM (4 years ago)
Author:
mark.lam@apple.com
Message:

mozilla-tests.yaml/js1_5/Array/regress-101964.js is frequently failing on JSC EWS bots.
https://bugs.webkit.org/show_bug.cgi?id=200789
<rdar://problem/54361916>

Reviewed by Keith Miller.

JSTests:

The prevailing theory is that this test is being pre-empted and not getting the
CPU time it needs to complete. As a result, the wall clock time period for
running the test exceeds the expected time. This patch tests this theory by
changing the time measurement to use CPU time instead.

  • mozilla/js1_5/Array/regress-101964.js:

Source/JavaScriptCore:

  • tools/JSDollarVM.cpp:

(JSC::functionCurrentCPUTime):
(JSC::JSDollarVM::finishCreation):

Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/JSTests/ChangeLog

    r252975 r253008  
     12019-12-02  Mark Lam  <mark.lam@apple.com>
     2
     3        mozilla-tests.yaml/js1_5/Array/regress-101964.js is frequently failing on JSC EWS bots.
     4        https://bugs.webkit.org/show_bug.cgi?id=200789
     5        <rdar://problem/54361916>
     6
     7        Reviewed by Keith Miller.
     8
     9        The prevailing theory is that this test is being pre-empted and not getting the
     10        CPU time it needs to complete.  As a result, the wall clock time period for
     11        running the test exceeds the expected time.  This patch tests this theory by
     12        changing the time measurement to use CPU time instead.
     13
     14        * mozilla/js1_5/Array/regress-101964.js:
     15
    1162019-12-01  Caio Lima  <ticaiolima@gmail.com>
    217
  • trunk/JSTests/mozilla/js1_5/Array/regress-101964.js

    r209596 r253008  
    4747status = inSection(1);
    4848var arr = Array(BIG);
    49 var start = new Date();
     49var start = $vm.currentCPUTime();
    5050arr.length = LITTLE;
    5151actual = elapsedTime(start);
     
    6363function elapsedTime(startTime)
    6464{
    65   return new Date() - startTime;
     65  return $vm.currentCPUTime() - startTime;
    6666}
    6767
  • trunk/Source/JavaScriptCore/ChangeLog

    r253007 r253008  
     12019-12-02  Mark Lam  <mark.lam@apple.com>
     2
     3        mozilla-tests.yaml/js1_5/Array/regress-101964.js is frequently failing on JSC EWS bots.
     4        https://bugs.webkit.org/show_bug.cgi?id=200789
     5        <rdar://problem/54361916>
     6
     7        Reviewed by Keith Miller.
     8
     9        * tools/JSDollarVM.cpp:
     10        (JSC::functionCurrentCPUTime):
     11        (JSC::JSDollarVM::finishCreation):
     12
    1132019-12-02  Yusuke Suzuki  <ysuzuki@apple.com>
    214
  • trunk/Source/JavaScriptCore/tools/JSDollarVM.cpp

    r252767 r253008  
    5454#include "WasmCapabilities.h"
    5555#include <wtf/Atomics.h>
     56#include <wtf/CPUTime.h>
    5657#include <wtf/DataLog.h>
    5758#include <wtf/ProcessID.h>
     
    26762677}
    26772678
     2679static EncodedJSValue JSC_HOST_CALL functionCurrentCPUTime(JSGlobalObject*, CallFrame*)
     2680{
     2681    DollarVMAssertScope assertScope;
     2682    return JSValue::encode(jsNumber(CPUTime::forCurrentThread().value()));
     2683}
     2684
    26782685static EncodedJSValue JSC_HOST_CALL functionTotalGCTime(JSGlobalObject* globalObject, CallFrame*)
    26792686{
     
    28332840    addFunction(vm, "deltaBetweenButterflies", functionDeltaBetweenButterflies, 2);
    28342841   
     2842    addFunction(vm, "currentCPUTime", functionCurrentCPUTime, 0);
    28352843    addFunction(vm, "totalGCTime", functionTotalGCTime, 0);
    28362844
Note: See TracChangeset for help on using the changeset viewer.