Changeset 253034 in webkit


Ignore:
Timestamp:
Dec 3, 2019 3:25:49 AM (4 years ago)
Author:
Fujii Hironori
Message:

Unreviewed, rolling out r253020.

It breaks WinCairo bots.

Reverted changeset:

"[MSVC] Add /experimental:newLambdaProcessor switch for better
C++ conformance"
​https://bugs.webkit.org/show_bug.cgi?id=204443
​https://trac.webkit.org/changeset/253020

Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/ChangeLog

    r253020 r253034  
     12019-12-03  Fujii Hironori  <Hironori.Fujii@sony.com>
     2
     3        Unreviewed, rolling out r253020.
     4
     5        It breaks WinCairo bots.
     6
     7        Reverted changeset:
     8
     9        "[MSVC] Add /experimental:newLambdaProcessor switch for better
     10        C++ conformance"
     11        https://bugs.webkit.org/show_bug.cgi?id=204443
     12        https://trac.webkit.org/changeset/253020
     13
    1142019-12-02  Fujii Hironori  <Hironori.Fujii@sony.com>
    215

  • trunk/Source/WebCore/ChangeLog

    r253033 r253034  
     12019-12-03  Fujii Hironori  <Hironori.Fujii@sony.com>
     2
     3        Unreviewed, rolling out r253020.
     4
     5        It breaks WinCairo bots.
     6
     7        Reverted changeset:
     8
     9        "[MSVC] Add /experimental:newLambdaProcessor switch for better
     10        C++ conformance"
     11        https://bugs.webkit.org/show_bug.cgi?id=204443
     12        https://trac.webkit.org/changeset/253020
     13
    1142019-12-03  youenn fablet  <youenn@apple.com>
    215

  • trunk/Source/WebCore/dom/DocumentStorageAccess.cpp

    r253020 r253034  
    183183
    184184        if (shouldPreserveUserGesture) {
    185             m_document.eventLoop().queueMicrotask([this, weakThis = makeWeakPtr(*this)] {
     185            m_document.eventLoop().queueMicrotask([this, weakThis = makeWeakPtr(*weakThis)] {
    186186                if (weakThis)
    187187                    enableTemporaryTimeUserGesture();
    … …  
    198198
    199199        if (shouldPreserveUserGesture) {
    200             m_document.eventLoop().queueMicrotask([this, weakThis = makeWeakPtr(*this)] {
     200            m_document.eventLoop().queueMicrotask([this, weakThis = makeWeakPtr(*weakThis)] {
    201201                if (weakThis)
    202202                    consumeTemporaryTimeUserGesture();

  • trunk/Source/cmake/OptionsMSVC.cmake

    r253020 r253034  
    2929# Specify the source code encoding
    3030add_compile_options(/utf-8 /validate-charset)
    31 
    32 # Enable the new lambda processor for better C++ conformance with /std:c++17
    33 add_compile_options(/experimental:newLambdaProcessor)
    3431
    3532if (${CMAKE_BUILD_TYPE} MATCHES "Debug")
Note: See TracChangeset for help on using the changeset viewer.