Changeset 25321 in webkit


Ignore:
Timestamp:
Aug 30, 2007 3:33:39 PM (17 years ago)
Author:
bdash
Message:

2007-08-30 Riku Voipio <riku.voipio@iki.fi>

Reviewed by Dave Kilzer.

Better ARM defines.

  • kjs/ustring.h: Update comments to reflect the change and update test to fit changes to Platform.h.
  • wtf/Platform.h: Forced packing is only needed on oldabi ARM. Set middle-endian floats only for little-endian oldabi ARM. Set big-endian define for big-endian ARM.

2007-08-30 Riku Voipio <riku.voipio@iki.fi>

Reviewed by Dave Kilzer.

Better ARM defines.

  • platform/DeprecatedString.h: Update comments to reflect the change and update test to fit changes to Platform.h.
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/JavaScriptCore/ChangeLog

    r25296 r25321  
     12007-08-30  Riku Voipio  <riku.voipio@iki.fi>
     2
     3        Reviewed by Dave Kilzer.
     4
     5        Better ARM defines.
     6
     7        * kjs/ustring.h: Update comments to reflect the change and update test
     8        to fit changes to Platform.h.
     9        * wtf/Platform.h: Forced packing is only needed on oldabi ARM.
     10        Set middle-endian floats only for little-endian oldabi ARM.
     11        Set big-endian define for big-endian ARM.
     12
    1132007-08-29  Ryan Leavengood <leavengood@gmail.com>
    214
  • trunk/JavaScriptCore/kjs/ustring.h

    r24919 r25321  
    3333#include <wtf/RefPtr.h>
    3434
    35 /* On ARM some versions of GCC don't pack structures by default so sizeof(UChar)
     35/* On some ARM platforms GCC won't pack structures by default so sizeof(UChar)
    3636   will end up being != 2 which causes crashes since the code depends on that. */
    37 #if COMPILER(GCC) && PLATFORM(ARM)
     37#if COMPILER(GCC) && PLATFORM(FORCE_PACK)
    3838#define PACK_STRUCT __attribute__((packed))
    3939#else
  • trunk/JavaScriptCore/wtf/Platform.h

    r25253 r25321  
    131131   || defined(__arm__)
    132132#define WTF_PLATFORM_ARM 1
     133#if defined(__ARMEB__)
     134#define WTF_PLATFORM_BIG_ENDIAN 1
     135#elif !defined(__ARM_EABI__) && !defined(__ARMEB__)
    133136#define WTF_PLATFORM_MIDDLE_ENDIAN 1
     137#endif
     138#if !defined(__ARM_EABI__)
     139#define WTF_PLATFORM_FORCE_PACK 1
     140#endif
    134141#endif
    135142
  • trunk/WebCore/ChangeLog

    r25319 r25321  
     12007-08-30  Riku Voipio  <riku.voipio@iki.fi>
     2
     3        Reviewed by Dave Kilzer.
     4
     5        Better ARM defines.
     6
     7        * platform/DeprecatedString.h: Update comments to reflect the
     8        change and update test to fit changes to Platform.h.
     9
    1102007-08-30  Darin Adler  <darin@apple.com>
    211
  • trunk/WebCore/platform/DeprecatedString.h

    r24946 r25321  
    3333#include <ctype.h>
    3434
    35 /* On ARM some versions of GCC don't pack structures by default so sizeof(DeprecatedChar)
     35/* On some ARM platforms GCC won't pack structures by default so sizeof(DeprecatedChar)
    3636   will end up being != 2 which causes crashes since the code depends on that. */
    37 #if COMPILER(GCC) && PLATFORM(ARM)
     37#if COMPILER(GCC) && PLATFORM(FORCE_PACK)
    3838#define PACK_STRUCT __attribute__((packed))
    3939#else
Note: See TracChangeset for help on using the changeset viewer.