Changeset 253368 in webkit
- Timestamp:
- Dec 11, 2019 6:04:48 AM (4 years ago)
- Location:
- trunk
- Files:
-
- 9 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r253356 r253368 1 2019-12-11 Thibault Saunier <tsaunier@igalia.com> 2 3 [GStreamer][MediaStream] Fix GStreamer capturer mock 4 https://bugs.webkit.org/show_bug.cgi?id=205066 5 6 - Presets where wrongly generated based on GStreamer capabilities 7 - Audio capturer was not taking into account echo cancellation 8 9 Reviewed by Philippe Normand. 10 11 * platform/gtk/TestExpectations: Updated expectations as required 12 * platform/wpe/TestExpectations: Updated expectations as required 13 1 14 2019-12-10 Peng Liu <peng.liu6@apple.com> 2 15 -
trunk/LayoutTests/platform/gtk/TestExpectations
r253312 r253368 574 574 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-stats.html [ Timeout Crash ] 575 575 webkit.org/b/79203 fast/mediastream/get-display-media-muted.html [ Timeout ] 576 webkit.org/b/79203 fast/mediastream/constraint-intrinsic-size.html [ Skip ] 576 577 webkit.org/b/151344 fast/mediastream/MediaStream-add-ended-tracks.html [ Timeout ] 578 webkit.org/b/205057 fast/mediastream/MediaStreamTrack-getSettings.html [ Failure ] 577 579 # Crash is bug #176801 578 580 webkit.org/b/160996 fast/mediastream/MediaStream-video-element-video-tracks-disabled.html [ ImageOnlyFailure Crash ] … … 2206 2208 2207 2209 webkit.org/b/191886 fast/mediastream/MediaStream-video-element-remove-track.html [ Failure ] 2210 2208 2211 2209 2212 # Console log lines may appear in a different order so we silence them. … … 3753 3756 webkit.org/b/199002 compositing/repaint/scroller-with-foreground-layer-repaints.html [ Failure ] 3754 3757 webkit.org/b/199004 fast/events/fire-mousedown-while-pressing-mouse-button.html [ Failure ] 3755 webkit.org/b/199006 fast/mediastream/MediaStreamTrack-getCapabilities.html [ Failure ]3756 3758 3757 3759 webkit.org/b/199009 fast/text/variations/optical-sizing-units.html [ ImageOnlyFailure ] … … 3762 3764 webkit.org/b/199860 accessibility/datalist.html [ Failure ] 3763 3765 webkit.org/b/199868 accessibility/gtk/aria-haspopup.html [ Failure ] 3764 3765 webkit.org/b/199440 fast/mediastream/apply-constraints-video.html [ Failure ]3766 webkit.org/b/199440 fast/mediastream/getUserMedia-video-rescaling.html [ Failure ]3767 3766 3768 3767 webkit.org/b/199437 compositing/geometry/limit-layer-bounds-clipping-ancestor.html [ Failure ] -
trunk/LayoutTests/platform/wpe/TestExpectations
r253312 r253368 116 116 webkit.org/b/160996 fast/mediastream/MediaStream-video-element-video-tracks-disabled.html [ Timeout ImageOnlyFailure Crash ] 117 117 webkit.org/b/173257 fast/mediastream/getUserMedia-grant-persistency3.html [ Pass Failure ] 118 119 webkit.org/b/205057 fast/mediastream/MediaStreamTrack-getSettings.html [ Failure ] 118 120 119 121 # Canvas captureStream support is not implemented … … 1872 1874 1873 1875 webkit.org/b/192886 fast/mediastream/media-stream-renders-first-frame.html [ Failure ] 1876 webkit.org/b/192888 fast/mediastream/resize-letterbox.html [ Failure ] 1877 webkit.org/b/192888 fast/mediastream/resize-trim.html [ Failure ] 1878 1879 # No support for screen capture 1880 webkit.org/b/79203 fast/mediastream/screencapture-user-gesture.html [ Skip ] 1881 webkit.org/b/79203 fast/mediastream/get-display-media-muted.html [ Skip ] 1882 webkit.org/b/79203 fast/mediastream/constraint-intrinsic-size.html [ Skip ] 1883 webkit.org/b/198113 fast/mediastream/media-stream-page-muted.html [ Timeout Pass ] 1874 1884 1875 1885 webkit.org/b/192891 fast/writing-mode/vertical-align-table-baseline.html [ Failure ] … … 1931 1941 1932 1942 webkit.org/b/196199 http/tests/IndexedDB/storage-limit-1.https.html [ Failure ] 1933 1934 webkit.org/b/199440 fast/mediastream/apply-constraints-video.html [ Failure ]1935 webkit.org/b/199440 fast/mediastream/getUserMedia-video-rescaling.html [ Failure ]1936 1943 1937 1944 webkit.org/b/200301 storage/websql/alter-to-info-table.html [ Failure ] -
trunk/Source/WebCore/ChangeLog
r253367 r253368 1 2019-12-11 Thibault Saunier <tsaunier@igalia.com> 2 3 [GStreamer][MediaStream] Fix GStreamer capturer mock 4 https://bugs.webkit.org/show_bug.cgi?id=205066 5 6 - Presets where wrongly generated based on GStreamer capabilities 7 - Audio capturer was not taking into account echo cancellation 8 9 Reviewed by Philippe Normand. 10 11 This fixes a few tests 12 13 * platform/mediastream/RealtimeVideoCaptureSource.h: 14 (WebCore::RealtimeVideoCaptureSource::canResizeVideoFrames const): 15 * platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h: 16 * platform/mediastream/gstreamer/MockGStreamerAudioCaptureSource.cpp: 17 (WebCore::WrappedMockRealtimeAudioSource::addHum): 18 * platform/mediastream/gstreamer/MockGStreamerVideoCaptureSource.cpp: 19 (WebCore::WrappedMockRealtimeVideoSource::presets): 20 (WebCore::MockGStreamerVideoCaptureSource::generatePresets): 21 * platform/mediastream/gstreamer/MockGStreamerVideoCaptureSource.h: 22 * platform/mock/MockRealtimeVideoSource.h: 23 1 24 2019-12-11 Charlie Turner <cturner@igalia.com> 2 25 -
trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h
r247347 r253368 50 50 void stopProducingData() override; 51 51 bool canResizeVideoFrames() const final { return true; } 52 void generatePresets() final;52 void generatePresets() override; 53 53 54 54 -
trunk/Source/WebCore/platform/mediastream/gstreamer/MockGStreamerAudioCaptureSource.cpp
r252681 r253368 63 63 void addHum(float amplitude, float frequency, float sampleRate, uint64_t start, float *p, uint64_t count) 64 64 { 65 if (echoCancellation()) { 66 GST_DEBUG("echo cancel off..., no hum"); 67 return; 68 } 65 69 float humPeriod = sampleRate / frequency; 66 70 for (uint64_t i = start, end = start + count; i < end; ++i) { -
trunk/Source/WebCore/platform/mediastream/gstreamer/MockGStreamerVideoCaptureSource.cpp
r247407 r253368 43 43 return *this; 44 44 } 45 46 const Vector<Ref<VideoPreset>>& presets() 47 { 48 return MockRealtimeVideoSource::presets(); 49 } 50 51 bool canResizeVideoFrames() const final { return true; } 45 52 46 53 void updateSampleBuffer() … … 142 149 } 143 150 151 void MockGStreamerVideoCaptureSource::generatePresets() 152 { 153 setSupportedPresets(m_wrappedSource->presets()); 154 } 155 144 156 void MockGStreamerVideoCaptureSource::captureFailed() 145 157 { -
trunk/Source/WebCore/platform/mediastream/gstreamer/MockGStreamerVideoCaptureSource.h
r247407 r253368 41 41 42 42 private: 43 void generatePresets() final; 43 44 void stopProducingData() final; 44 45 void startProducingData() final; -
trunk/Source/WebCore/platform/mock/MockRealtimeVideoSource.h
r248046 r253368 63 63 void settingsDidChange(OptionSet<RealtimeMediaSourceSettings::Flag>) override; 64 64 MediaSample::VideoRotation sampleRotation() const final { return m_deviceOrientation; } 65 void generatePresets() override; 65 66 66 67 private: … … 77 78 IntSize captureSize() const; 78 79 79 void generatePresets() final;80 80 81 81 bool isMockSource() const final { return true; }
Note: See TracChangeset
for help on using the changeset viewer.