Changeset 253847 in webkit

Timestamp:

Dec 20, 2019 2:59:44 PM (4 years ago)

Author:

Chris Dumez

Message:

sendBeacon on Safari 13 seeing high failure rates
​https://bugs.webkit.org/show_bug.cgi?id=204665
<rdar://problem/57522622>

Reviewed by Darin Adler.

Revert r245344 to try and reduce our failure rate for Beacon. This is the only change
to our Beacon implementation that I am aware we made in Safari 13. Using a lower priority
for Beacon makes it more likely that the Beacon load is still pending when the network
process exits, which would interrupt the Beacon.

Since we're trying to convince developers to move away from synchronous XHR and to using
the Beacon API intead, it is important that our Beacon API be as reliable as possible.

• Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::sendBeacon):

• loader/PingLoader.cpp:

(WebCore::PingLoader::sendPing):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/beacon/NavigatorBeacon.cpp (modified) (1 diff)
• loader/PingLoader.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-12-20  Chris Dumez  <cdumez@apple.com>
+
+        sendBeacon on Safari 13 seeing high failure rates
+        https://bugs.webkit.org/show_bug.cgi?id=204665
+        <rdar://problem/57522622>
+
+        Reviewed by Darin Adler.
+
+        Revert r245344 to try and reduce our failure rate for Beacon. This is the only change
+        to our Beacon implementation that I am aware we made in Safari 13. Using a lower priority
+        for Beacon makes it more likely that the Beacon load is still pending when the network
+        process exits, which would interrupt the Beacon.
+
+        Since we're trying to convince developers to move away from synchronous XHR and to using
+        the Beacon API intead, it is important that our Beacon API be as reliable as possible.
+
+        * Modules/beacon/NavigatorBeacon.cpp:
+        (WebCore::NavigatorBeacon::sendBeacon):
+        * loader/PingLoader.cpp:
+        (WebCore::PingLoader::sendPing):
+
 2019-12-20  Truitt Savell  <tsavell@apple.com>
 

trunk/Source/WebCore/Modules/beacon/NavigatorBeacon.cpp

@@ -122 +122 @@
     ResourceRequest request(parsedUrl);
     request.setHTTPMethod("POST"_s);
-    request.setPriority(ResourceLoadPriority::VeryLow);
 
     ResourceLoaderOptions options;

trunk/Source/WebCore/loader/PingLoader.cpp

@@ -131 +131 @@
     request.setHTTPBody(FormData::create("PING"));
     request.setHTTPHeaderField(HTTPHeaderName::CacheControl, "max-age=0");
-    request.setPriority(ResourceLoadPriority::VeryLow);
 
     HTTPHeaderMap originalRequestHeader = request.httpHeaderFields();