Changeset 253855 in webkit
- Timestamp:
- Dec 20, 2019 5:04:28 PM (4 years ago)
- Location:
- trunk
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/imported/w3c/ChangeLog
r253832 r253855 1 2019-12-20 Chris Dumez <cdumez@apple.com> 2 3 [Bindings] Add @@toStringTag to our iterator prototype object 4 https://bugs.webkit.org/show_bug.cgi?id=205516 5 6 Reviewed by Darin Adler. 7 8 Rebaseline WPT tests that are now passing. 9 10 * web-platform-tests/WebIDL/ecmascript-binding/default-iterator-object-expected.txt: 11 * web-platform-tests/WebIDL/ecmascript-binding/iterator-prototype-object-expected.txt: 12 1 13 2019-12-20 Truitt Savell <tsavell@apple.com> 2 14 -
trunk/LayoutTests/imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/default-iterator-object-expected.txt
r232641 r253855 2 2 PASS Default iterator objects for an interface have the same prototype 3 3 PASS Object.prototype.toString returns correct value 4 FAIL @@toStringTag has correct value from prototype assert_equals: expected (string) "URLSearchParams Iterator" but got (undefined) undefined 4 PASS @@toStringTag has correct value from prototype 5 5 -
trunk/LayoutTests/imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/iterator-prototype-object-expected.txt
r232641 r253855 4 4 PASS next() throws TypeError when called on ineligible receiver 5 5 PASS Object.prototype.toString returns correct value 6 FAIL @@toStringTag has correct value undefined is not an object (evaluating 'Object.getOwnPropertyDescriptor(iteratorProto, Symbol.toStringTag).value') 6 PASS @@toStringTag has correct value 7 7 PASS Is specific to an interface 8 8 -
trunk/Source/WebCore/ChangeLog
r253852 r253855 1 2019-12-20 Chris Dumez <cdumez@apple.com> 2 3 [Bindings] Add @@toStringTag to our iterator prototype object 4 https://bugs.webkit.org/show_bug.cgi?id=205516 5 6 Reviewed by Darin Adler. 7 8 Add @@ toStringTag to our iterator prototype object, as per: 9 - https://heycam.github.io/webidl/#es-iterator-prototype-object 10 11 No new tests, rebaselined existing tests. 12 13 * bindings/js/JSDOMIterator.h: 14 (WebCore::IteratorTraits>::finishCreation): 15 1 16 2019-12-20 Jer Noble <jer.noble@apple.com> 2 17 -
trunk/Source/WebCore/bindings/js/JSDOMIterator.h
r251425 r253855 29 29 #include "JSDOMConvert.h" 30 30 #include <JavaScriptCore/IteratorPrototype.h> 31 #include <JavaScriptCore/PropertySlot.h> 31 32 #include <type_traits> 32 33 … … 265 266 ASSERT(inherits(vm, info())); 266 267 268 putDirectWithoutTransition(vm, vm.propertyNames->toStringTagSymbol, jsString(vm, info()->className), JSC::PropertyAttribute::DontEnum | JSC::PropertyAttribute::ReadOnly); 267 269 JSC_NATIVE_INTRINSIC_FUNCTION_WITHOUT_TRANSITION(vm.propertyNames->next, next, 0, 0, JSC::NoIntrinsic); 268 270 }
Note: See TracChangeset
for help on using the changeset viewer.