Changeset 253974 in webkit

Timestamp:

Jan 2, 2020 1:04:54 AM (4 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] Make ondemand hardware acceleration policy never leave AC mode
​https://bugs.webkit.org/show_bug.cgi?id=205558

Reviewed by Sergio Villar Senin.

We still enter AC mode on demand but we never leave it for the same drawing area. This avoids scrolling
performance problems with some websites that start small accelerated animation while scrolling (like WebKit
bugzilla review tool), due to constant enter/leave AC mode.

• UIProcess/API/glib/WebKitSettings.cpp:

(webkit_settings_class_init): Update API documentation.

• WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:

(WebKit::DrawingAreaCoordinatedGraphics::enterAcceleratedCompositingMode): Force AC mode the first time we enter it.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/glib/WebKitSettings.cpp (modified) (1 diff)
• WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Make ondemand hardware acceleration policy never leave AC mode
+        https://bugs.webkit.org/show_bug.cgi?id=205558
+
+        Reviewed by Sergio Villar Senin.
+
+        We still enter AC mode on demand but we never leave it for the same drawing area. This avoids scrolling
+        performance problems with some websites that start small accelerated animation while scrolling (like WebKit
+        bugzilla review tool), due to constant enter/leave AC mode.
+
+        * UIProcess/API/glib/WebKitSettings.cpp:
+        (webkit_settings_class_init): Update API documentation.
+        * WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
+        (WebKit::DrawingAreaCoordinatedGraphics::enterAcceleratedCompositingMode): Force AC mode the first time we enter it.
+
 2019-12-22  Jeff Miller  <jeffm@apple.com>
 

trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp

@@ -1442 +1442 @@
      * The #WebKitHardwareAccelerationPolicy to decide how to enable and disable
      * hardware acceleration. The default value %WEBKIT_HARDWARE_ACCELERATION_POLICY_ON_DEMAND
-     * enables the hardware acceleration when the web contents request it, disabling it again
-     * when no longer needed. It's possible to enforce hardware acceleration to be always enabled
+     * enables the hardware acceleration when the web contents request it.
+     * It's possible to enforce hardware acceleration to be always enabled
      * by using %WEBKIT_HARDWARE_ACCELERATION_POLICY_ALWAYS. And it's also possible to disable it
      * completely using %WEBKIT_HARDWARE_ACCELERATION_POLICY_NEVER. Note that disabling hardware

trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp

@@ -558 +558 @@
 void DrawingAreaCoordinatedGraphics::enterAcceleratedCompositingMode(GraphicsLayer* graphicsLayer)
 {
+#if PLATFORM(GTK)
+    if (!m_alwaysUseCompositing) {
+        m_webPage.corePage()->settings().setForceCompositingMode(true);
+        m_alwaysUseCompositing = true;
+    }
+#endif
     m_discardPreviousLayerTreeHostTimer.stop();