Changeset 254008 in webkit


Ignore:
Timestamp:
Jan 3, 2020 10:35:59 AM (4 years ago)
Author:
Wenson Hsieh
Message:

highlight/highlight-world-leak.html frequently times out
https://bugs.webkit.org/show_bug.cgi?id=205643
<rdar://problem/58263350>

Reviewed by Megan Gardner.

The main logic in this test is executed inside a load event handler to a subframe, which is set in a script
element. However, in the case where the subframe finishes loading before we execute the inline script, the test
will never run, since the load event handler won't be called again.

Fix this by waiting for the load event of the page instead.

  • highlight/highlight-world-leak.html:
Location:
trunk/LayoutTests
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r254007 r254008  
     12020-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
     2
     3        highlight/highlight-world-leak.html frequently times out
     4        https://bugs.webkit.org/show_bug.cgi?id=205643
     5        <rdar://problem/58263350>
     6
     7        Reviewed by Megan Gardner.
     8
     9        The main logic in this test is executed inside a load event handler to a subframe, which is set in a script
     10        element. However, in the case where the subframe finishes loading before we execute the inline script, the test
     11        will never run, since the load event handler won't be called again.
     12
     13        Fix this by waiting for the load event of the page instead.
     14
     15        * highlight/highlight-world-leak.html:
     16
    1172020-01-03  youenn fablet  <youenn@apple.com>
    218
  • trunk/LayoutTests/highlight/highlight-world-leak.html

    r253857 r254008  
    2222
    2323var testFrame = document.getElementById("testFrame");
    24 testFrame.onload = function() {
     24onload = function() {
    2525    let frameDocumentIdentifier = internals.documentIdentifier(testFrame.contentDocument);
    2626    testFrame.remove();
Note: See TracChangeset for help on using the changeset viewer.