Changeset 254330 in webkit

Timestamp:

Jan 10, 2020 12:45:56 AM (4 years ago)

Author:

Carlos Garcia Campos

Message:

Automation: resolveChildFrameWithNodeHandle should return NodeNotFound when node doesn't exist
​https://bugs.webkit.org/show_bug.cgi?id=205993

Reviewed by Brian Burg.

According to the spec:

"If element is stale, return error with error code stale element reference."
​https://w3c.github.io/webdriver/#switch-to-frame

Fixes: imported/w3c/webdriver/tests/switch_to_frame/switch.py::test_frame_id_webelement_stale_reference

• WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::resolveChildFrameWithNodeHandle):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/Automation/WebAutomationSessionProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Automation: resolveChildFrameWithNodeHandle should return NodeNotFound when node doesn't exist
+        https://bugs.webkit.org/show_bug.cgi?id=205993
+
+        Reviewed by Brian Burg.
+
+        According to the spec:
+
+        "If element is stale, return error with error code stale element reference."
+        https://w3c.github.io/webdriver/#switch-to-frame
+
+        Fixes: imported/w3c/webdriver/tests/switch_to_frame/switch.py::test_frame_id_webelement_stale_reference
+
+        * WebProcess/Automation/WebAutomationSessionProxy.cpp:
+        (WebKit::WebAutomationSessionProxy::resolveChildFrameWithNodeHandle):
+
 2020-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp

@@ -440 +440 @@
 
     WebCore::Element* coreElement = elementForNodeHandle(*frame, nodeHandle);
+    if (!coreElement) {
+        String nodeNotFoundErrorType = Inspector::Protocol::AutomationHelpers::getEnumConstantValue(Inspector::Protocol::Automation::ErrorMessage::NodeNotFound);
+        completionHandler(nodeNotFoundErrorType, WTF::nullopt);
+        return;
+    }
+
     if (!is<WebCore::HTMLFrameElementBase>(coreElement)) {
         completionHandler(frameNotFoundErrorType, WTF::nullopt);