Changeset 254341 in webkit


Ignore:
Timestamp:
Jan 10, 2020 8:48:40 AM (4 years ago)
Author:
youenn@apple.com
Message:

[WTR] Use short heart beat timer as a TestOption
​https://bugs.webkit.org/show_bug.cgi?id=205795

Reviewed by Chris Dumez.

Tools:

Using short service worker heartbeat timeout values creates flakiness on slow bots.
By default, use regular service worker heartbeat timeout values for layout tests.
Add a WTR option value to use short service worker timeout values.
Use this option for service worker spinning layout tests.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):

  • WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

LayoutTests:

  • http/wpt/service-workers/service-worker-spinning-activate.https.html:
  • http/wpt/service-workers/service-worker-spinning-fetch.https.html:
  • http/wpt/service-workers/service-worker-spinning-install.https.html:
  • http/wpt/service-workers/service-worker-spinning-message.https.html:
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r254338 r254341  
     12020-01-10  youenn fablet  <youenn@apple.com>
     2
     3        [WTR] Use short heart beat timer as a TestOption
     4        https://bugs.webkit.org/show_bug.cgi?id=205795
     5
     6        Reviewed by Chris Dumez.
     7
     8        * http/wpt/service-workers/service-worker-spinning-activate.https.html:
     9        * http/wpt/service-workers/service-worker-spinning-fetch.https.html:
     10        * http/wpt/service-workers/service-worker-spinning-install.https.html:
     11        * http/wpt/service-workers/service-worker-spinning-message.https.html:
     12
    1132020-01-10  Pablo Saavedra  <psaavedra@igalia.com>
    214

  • trunk/LayoutTests/http/wpt/service-workers/service-worker-spinning-activate.https.html

    r253898 r254341  
     1<!doctype html><!-- webkit-test-runner [ useServiceWorkerShortTimeout=true ] -->
    12<html>
    23<head>

  • trunk/LayoutTests/http/wpt/service-workers/service-worker-spinning-fetch.https.html

    r253898 r254341  
     1<!doctype html><!-- webkit-test-runner [ useServiceWorkerShortTimeout=true ] -->
    12<html>
    23<head>

  • trunk/LayoutTests/http/wpt/service-workers/service-worker-spinning-install.https.html

    r253898 r254341  
     1<!doctype html><!-- webkit-test-runner [ useServiceWorkerShortTimeout=true ] -->
    12<html>
    23<head>

  • trunk/LayoutTests/http/wpt/service-workers/service-worker-spinning-message.https.html

    r253898 r254341  
     1<!doctype html><!-- webkit-test-runner [ useServiceWorkerShortTimeout=true ] -->
    12<html>
    23<head>

  • trunk/Tools/ChangeLog

    r254340 r254341  
     12020-01-10  youenn fablet  <youenn@apple.com>
     2
     3        [WTR] Use short heart beat timer as a TestOption
     4        https://bugs.webkit.org/show_bug.cgi?id=205795
     5
     6        Reviewed by Chris Dumez.
     7
     8        Using short service worker heartbeat timeout values creates flakiness on slow bots.
     9        By default, use regular service worker heartbeat timeout values for layout tests.
     10        Add a WTR option value to use short service worker timeout values.
     11        Use this option for service worker spinning layout tests.
     12
     13        * WebKitTestRunner/TestController.cpp:
     14        (WTR::TestController::resetPreferencesToConsistentValues):
     15        (WTR::updateTestOptionsFromTestHeader):
     16        * WebKitTestRunner/TestOptions.h:
     17        (WTR::TestOptions::hasSameInitializationOptions const):
     18
    1192020-01-10  Jonathan Bedard  <jbedard@apple.com>
    220

  • trunk/Tools/WebKitTestRunner/TestController.cpp

    r254318 r254341  
    948948    WKPreferencesSetAudioPlaybackRequiresUserGesture(preferences, false);
    949949
    950     WKPreferencesSetShouldUseServiceWorkerShortTimeout(preferences, true);
     950    WKPreferencesSetShouldUseServiceWorkerShortTimeout(preferences, options.contextOptions.useServiceWorkerShortTimeout);
    951951
    952952    platformResetPreferencesToConsistentValues();
    … …  
    14351435        else if (key == "enableProcessSwapOnWindowOpen")
    14361436            testOptions.contextOptions.enableProcessSwapOnWindowOpen = parseBooleanTestHeaderValue(value);
     1437        else if (key == "useServiceWorkerShortTimeout")
     1438            testOptions.contextOptions.useServiceWorkerShortTimeout = parseBooleanTestHeaderValue(value);
    14371439        else if (key == "enableColorFilter")
    14381440            testOptions.enableColorFilter = parseBooleanTestHeaderValue(value);

  • trunk/Tools/WebKitTestRunner/TestOptions.h

    r254130 r254341  
    3939        bool enableProcessSwapOnNavigation { true };
    4040        bool enableProcessSwapOnWindowOpen { false };
     41        bool useServiceWorkerShortTimeout { false };
    4142
    4243        bool hasSameInitializationOptions(const ContextOptions& options) const
    … …  
    4546                || overrideLanguages != options.overrideLanguages
    4647                || enableProcessSwapOnNavigation != options.enableProcessSwapOnNavigation
    47                 || enableProcessSwapOnWindowOpen != options.enableProcessSwapOnWindowOpen)
     48                || enableProcessSwapOnWindowOpen != options.enableProcessSwapOnWindowOpen
     49                || useServiceWorkerShortTimeout != options.useServiceWorkerShortTimeout)
    4850                return false;
    4951            return true;
Note: See TracChangeset for help on using the changeset viewer.