Changeset 254363 in webkit


Ignore:
Timestamp:
Jan 10, 2020 12:39:31 PM (4 years ago)
Author:
Brent Fulgham
Message:

Remove com.apple.locationd.registration from the WebContent sandbox
​https://bugs.webkit.org/show_bug.cgi?id=206021
<rdar://problem/58451384>

Reviewed by Per Arne Vollan.

Now that we generate a dynamic extension for 'com.apple.locationd.registration', we should remove
the blanket allow rule from the sandbox.

Source/WebKit:

Test: fast/sandbox/ios/sandbox-mach-lookup.html

  • Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

LayoutTests:

  • fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
  • fast/sandbox/ios/sandbox-mach-lookup.html:
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r254356 r254363  
     12020-01-10  Brent Fulgham  <bfulgham@apple.com>
     2
     3        Remove com.apple.locationd.registration from the WebContent sandbox
     4        https://bugs.webkit.org/show_bug.cgi?id=206021
     5        <rdar://problem/58451384>
     6
     7        Reviewed by Per Arne Vollan.
     8
     9        Now that we generate a dynamic extension for 'com.apple.locationd.registration', we should remove
     10        the blanket allow rule from the sandbox.
     11
     12        * fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
     13        * fast/sandbox/ios/sandbox-mach-lookup.html:
     14
    1152020-01-10  Jiewen Tan  <jiewen_tan@apple.com>
    216

  • trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt

    r254351 r254363  
    77PASS internals.hasSandboxMachLookupAccessToXPCServiceName("com.apple.WebKit.WebContent", "com.apple.viewservice") is false
    88PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.TextInput") is false
     9PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.locationd.registration") is false
    910PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.nehelper") is false
    1011PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.nesessionmanager") is false

  • trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html

    r254351 r254363  
    1010    shouldBeFalse("internals.hasSandboxMachLookupAccessToXPCServiceName(\"com.apple.WebKit.WebContent\", \"com.apple.viewservice\")");
    1111    shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.TextInput\")");
     12    shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.locationd.registration\")");
    1213    shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.nehelper\")");
    1314    shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.nesessionmanager\")");

  • trunk/Source/WebKit/ChangeLog

    r254361 r254363  
     12020-01-10  Brent Fulgham  <bfulgham@apple.com>
     2
     3        Remove com.apple.locationd.registration from the WebContent sandbox
     4        https://bugs.webkit.org/show_bug.cgi?id=206021
     5        <rdar://problem/58451384>
     6
     7        Reviewed by Per Arne Vollan.
     8
     9        Now that we generate a dynamic extension for 'com.apple.locationd.registration', we should remove
     10        the blanket allow rule from the sandbox.
     11
     12        Test: fast/sandbox/ios/sandbox-mach-lookup.html
     13
     14        * Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
     15        * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
     16
    1172020-01-10  Simon Fraser  <simon.fraser@apple.com>
    218

  • trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb

    r254351 r254363  
    113113
    114114(define-once (location-services)
    115     (allow mach-lookup
    116            (global-name "com.apple.locationd.registration"))
    117115    (allow-carrier-bundle) ;; <rdar://problem/21192365>
    118116    (mobile-preferences-read

  • trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb

    r254351 r254363  
    126126
    127127(define-once (location-services)
    128     (allow mach-lookup (with report) (with telemetry)
    129            (global-name "com.apple.locationd.registration"))
    130128    (allow-carrier-bundle) ;; <rdar://problem/21192365>
    131129    (mobile-preferences-read
Note: See TracChangeset for help on using the changeset viewer.