Changeset 254379 in webkit


Ignore:
Timestamp:
Jan 10, 2020 4:21:59 PM (4 years ago)
Author:
Brent Fulgham
Message:

[iOS] Remove used media-related mach services from the WebContent process sandbox
​https://bugs.webkit.org/show_bug.cgi?id=206089
<rdar://problem/58489478>

Reviewed by Per Arne Vollan.

After conducting multiple test passes and large-scale living-on testing with telemetry, we have
confirmed that the following XPC services are not used by the media logic in WebKit, and can be
removed:

com.apple.coremedia.cpeprotector.xpc
com.apple.coremedia.figcontentkeysession.xpc
com.apple.coremedia.routingsessionmanager.xpc
com.apple.coremedia.sts

Source/WebKit:

Test: fast/sandbox/ios/sandbox-mach-lookup.html

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

LayoutTests:

  • fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
  • fast/sandbox/ios/sandbox-mach-lookup.html:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r254378 r254379  
     12020-01-10  Brent Fulgham  <bfulgham@apple.com>
     2
     3        [iOS] Remove used media-related mach services from the WebContent process sandbox
     4        https://bugs.webkit.org/show_bug.cgi?id=206089
     5        <rdar://problem/58489478>
     6
     7        Reviewed by Per Arne Vollan.
     8
     9        After conducting multiple test passes and large-scale living-on testing with telemetry, we have
     10        confirmed that the following XPC services are not used by the media logic in WebKit, and can be
     11        removed:
     12
     13            com.apple.coremedia.cpeprotector.xpc
     14            com.apple.coremedia.figcontentkeysession.xpc
     15            com.apple.coremedia.routingsessionmanager.xpc
     16            com.apple.coremedia.sts
     17
     18        * fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
     19        * fast/sandbox/ios/sandbox-mach-lookup.html:
     20
    1212020-01-10  Antti Koivisto  <antti@apple.com>
    222

  • trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt

    r254376 r254379  
    99PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.awdd") is false
    1010PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.cookied") is false
     11PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.coremedia.cpeprotector.xpc") is false
     12PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.coremedia.figcontentkeysession.xpc") is false
     13PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.coremedia.routingsessionmanager.xpc") is false
     14PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.coremedia.sts") is false
    1115PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.iohideventsystem") is false
    1216PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.locationd.registration") is false

  • trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html

    r254376 r254379  
    1212    shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.awdd\")");
    1313    shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.cookied\")");
     14    shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.coremedia.cpeprotector.xpc\")");
     15    shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.coremedia.figcontentkeysession.xpc\")");
     16    shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.coremedia.routingsessionmanager.xpc\")");
     17    shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.coremedia.sts\")");
    1418    shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.iohideventsystem\")");
    1519    shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.locationd.registration\")");

  • trunk/Source/WebKit/ChangeLog

    r254376 r254379  
     12020-01-10  Brent Fulgham  <bfulgham@apple.com>
     2
     3        [iOS] Remove used media-related mach services from the WebContent process sandbox
     4        https://bugs.webkit.org/show_bug.cgi?id=206089
     5        <rdar://problem/58489478>
     6
     7        Reviewed by Per Arne Vollan.
     8
     9        After conducting multiple test passes and large-scale living-on testing with telemetry, we have
     10        confirmed that the following XPC services are not used by the media logic in WebKit, and can be
     11        removed:
     12
     13            com.apple.coremedia.cpeprotector.xpc
     14            com.apple.coremedia.figcontentkeysession.xpc
     15            com.apple.coremedia.routingsessionmanager.xpc
     16            com.apple.coremedia.sts
     17
     18        Test: fast/sandbox/ios/sandbox-mach-lookup.html
     19
     20        * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
     21
    1222020-01-10  Brent Fulgham  <bfulgham@apple.com>
    223

  • trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb

    r254376 r254379  
    179179
    180180    (allow mach-lookup (with report) (with telemetry)
    181         (global-name "com.apple.coremedia.cpeprotector.xpc")
    182181        (global-name "com.apple.coremedia.endpoint.xpc")
    183         (global-name "com.apple.coremedia.figcontentkeysession.xpc")
    184         (global-name "com.apple.coremedia.figcpecryptor")
    185         (global-name "com.apple.coremedia.routingsessionmanager.xpc")
    186         (global-name "com.apple.coremedia.sts"))
     182        (global-name "com.apple.coremedia.figcpecryptor"))
    187183
    188184    (mobile-preferences-read
Note: See TracChangeset for help on using the changeset viewer.