Changeset 254393 in webkit

Timestamp:

Jan 10, 2020 10:54:45 PM (4 years ago)

Author:

ysuzuki@apple.com

Message:

[JSC] Flush old tables in End phase
​https://bugs.webkit.org/show_bug.cgi?id=206120
<rdar://problem/58039989>

Reviewed by Mark Lam.

JSTests:

• stress/create-many-realms.js: Added.

(foo):

Source/JavaScriptCore:

stopThePeriphery is stopping compiler threads and main thread (mutator), which means making m_worldIsStopped = true.
It is not for stopping all heap threads including a concurrent marker. The concurrent collector can work while executing
stopThePeriphery. This means that concurrent collectors can access to the old StructureIDTable while it is destroyed
in stopThePeriphery. Destroying old StructureIDTable in GC End phase, this is appropriate phase that we can ensure no
other threads (accessing to heap) are working including concurrent markers, mutator, and compiler threads.

• heap/Heap.cpp:

(JSC::Heap::runEndPhase):
(JSC::Heap::stopThePeriphery):

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/create-many-realms.js (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/heap/Heap.cpp (modified) (2 diffs)

trunk/JSTests/ChangeLog

@@ +1 @@
+2020-01-10  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Flush old tables in End phase
+        https://bugs.webkit.org/show_bug.cgi?id=206120
+        <rdar://problem/58039989>
+
+        Reviewed by Mark Lam.
+
+        * stress/create-many-realms.js: Added.
+        (foo):
+
 2020-01-10  Caitlin Potter  <caitp@igalia.com> and Alexey Shvayka  <shvaikalesh@gmail.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-01-10  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Flush old tables in End phase
+        https://bugs.webkit.org/show_bug.cgi?id=206120
+        <rdar://problem/58039989>
+
+        Reviewed by Mark Lam.
+
+        stopThePeriphery is stopping compiler threads and main thread (mutator), which means making m_worldIsStopped = true.
+        It is not for stopping all heap threads including a concurrent marker. The concurrent collector can work while executing
+        stopThePeriphery. This means that concurrent collectors can access to the old StructureIDTable while it is destroyed
+        in stopThePeriphery. Destroying old StructureIDTable in GC End phase, this is appropriate phase that we can ensure no
+        other threads (accessing to heap) are working including concurrent markers, mutator, and compiler threads.
+
+        * heap/Heap.cpp:
+        (JSC::Heap::runEndPhase):
+        (JSC::Heap::stopThePeriphery):
+
 2020-01-10  Caitlin Potter  <caitp@igalia.com> and Alexey Shvayka  <shvaikalesh@gmail.com>
 

trunk/Source/JavaScriptCore/heap/Heap.cpp

@@ -1517 +1517 @@
         vm().typeProfiler()->invalidateTypeSetCache(vm());
 
+    m_structureIDTable.flushOldTables();
+
     reapWeakHandles();
     pruneStaleEntriesFromWeakGCMaps();
@@ -1664 +1666 @@
         shadowChicken->update(vm(), vm().topCallFrame);
     
-    m_structureIDTable.flushOldTables();
     m_objectSpace.stopAllocating();