Changeset 254410 in webkit

Timestamp:

Jan 11, 2020 8:21:40 PM (4 years ago)

Author:

Alan Bujtas

Message:

[LFC] Introduce the concept of independent formatting context
​https://bugs.webkit.org/show_bug.cgi?id=206137
<rdar://problem/58508015>

Reviewed by Sam Weinig.

At this point it is just about absolute positioned block level boxes since we don't support the "contain" property.
​https://www.w3.org/TR/css-display-3/#independent-formatting-context

• layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::establishesFormattingContext const):
(WebCore::Layout::Box::establishesIndependentFormattingContext const):

• layout/layouttree/LayoutBox.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• layout/layouttree/LayoutBox.cpp (modified) (2 diffs)
• layout/layouttree/LayoutBox.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-01-11  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC] Introduce the concept of independent formatting context
+        https://bugs.webkit.org/show_bug.cgi?id=206137
+        <rdar://problem/58508015>
+
+        Reviewed by Sam Weinig.
+
+        At this point it is just about absolute positioned block level boxes since we don't support the "contain" property.
+        https://www.w3.org/TR/css-display-3/#independent-formatting-context
+
+        * layout/layouttree/LayoutBox.cpp:
+        (WebCore::Layout::Box::establishesFormattingContext const):
+        (WebCore::Layout::Box::establishesIndependentFormattingContext const):
+        * layout/layouttree/LayoutBox.h:
+
 2020-01-11  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebCore/layout/layouttree/LayoutBox.cpp

@@ -76 +76 @@
     // We need the final tree structure to tell whether a box establishes a certain formatting context. 
     ASSERT(!Phase::isInTreeBuilding());
-    return establishesBlockFormattingContext() || establishesInlineFormattingContext() || establishesTableFormattingContext();
+    return establishesBlockFormattingContext() || establishesInlineFormattingContext() || establishesTableFormattingContext() || establishesIndependentFormattingContext();
 }
 
@@ -130 +130 @@
 {
     return isTableBox();
+}
+
+bool Box::establishesIndependentFormattingContext() const
+{
+    // FIXME: This is where we would check for 'contain' property.
+    return isAbsolutelyPositioned();
 }
 

trunk/Source/WebCore/layout/layouttree/LayoutBox.h

@@ -70 +70 @@
     bool establishesFormattingContext() const;
     bool establishesBlockFormattingContext() const;
+    bool establishesInlineFormattingContext() const;
     bool establishesTableFormattingContext() const;
+    bool establishesIndependentFormattingContext() const;
+
     bool establishesBlockFormattingContextOnly() const;
-    bool establishesInlineFormattingContext() const;
     bool establishesInlineFormattingContextOnly() const;