Changeset 254458 in webkit
- Timestamp:
- Jan 13, 2020 3:06:30 PM (4 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r254454 r254458 1 2020-01-13 Sunny He <sunny_he@apple.com> 2 3 Fix computeFloatVisibleRectInContainer to handle non-SVG object parent 4 https://bugs.webkit.org/show_bug.cgi?id=205282 5 6 Reviewed by Darin Adler. 7 8 * svg/dom/replaceChild-document-crash-expected.txt: Added. 9 * svg/dom/replaceChild-document-crash.html: Added. 10 1 11 2020-01-13 Eric Carlson <eric.carlson@apple.com> 2 12 -
trunk/Source/WebCore/ChangeLog
r254454 r254458 1 2020-01-13 Sunny He <sunny_he@apple.com> 2 3 Fix computeFloatVisibleRectInContainer to handle non-SVG object parent 4 https://bugs.webkit.org/show_bug.cgi?id=205282 5 <rdar://problem/57975185> 6 7 Reviewed by Darin Adler. 8 9 Test: svg/dom/replaceChild-document-crash.html 10 11 * rendering/svg/SVGRenderSupport.cpp: 12 (WebCore::SVGRenderSupport::computeFloatVisibleRectInContainer): 13 1 14 2020-01-13 Eric Carlson <eric.carlson@apple.com> 2 15 -
trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp
r239427 r254458 65 65 Optional<FloatRect> SVGRenderSupport::computeFloatVisibleRectInContainer(const RenderElement& renderer, const FloatRect& rect, const RenderLayerModelObject* container, RenderObject::VisibleRectContext context) 66 66 { 67 // Ensure our parent is an SVG object. 68 ASSERT(renderer.parent()); 69 auto& parent = *renderer.parent(); 70 if (!is<SVGElement>(parent.element())) 71 return FloatRect(); 72 67 73 FloatRect adjustedRect = rect; 68 74 const SVGRenderStyle& svgStyle = renderer.style().svgStyle(); … … 73 79 // Translate to coords in our parent renderer, and then call computeFloatVisibleRectInContainer() on our parent. 74 80 adjustedRect = renderer.localToParentTransform().mapRect(adjustedRect); 75 return renderer.parent()->computeFloatVisibleRectInContainer(adjustedRect, container, context); 81 82 return parent.computeFloatVisibleRectInContainer(adjustedRect, container, context); 76 83 } 77 84
Note: See TracChangeset
for help on using the changeset viewer.