Changeset 254473 in webkit

Timestamp:

Jan 13, 2020 5:08:49 PM (4 years ago)

Author:

ddkilzer@apple.com

Message:

WTR::TestController::decidePolicyForPluginLoad() should output bundle identifier on release assert
<​https://webkit.org/b/206105>

Reviewed by Brent Fulgham.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::decidePolicyForPluginLoad): Change
RELEASE_ASSERT_NOT_REACHED() to
RELEASE_ASSERT_NOT_REACHED_WITH_MESSAGE() with bundle
identifier.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/TestController.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-01-13  David Kilzer  <ddkilzer@apple.com>
+
+        WTR::TestController::decidePolicyForPluginLoad() should output bundle identifier on release assert
+        <https://webkit.org/b/206105>
+
+        Reviewed by Brent Fulgham.
+
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::decidePolicyForPluginLoad): Change
+        RELEASE_ASSERT_NOT_REACHED() to
+        RELEASE_ASSERT_NOT_REACHED_WITH_MESSAGE() with bundle
+        identifier.
+
 2020-01-13  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/WebKitTestRunner/TestController.cpp

@@ -2309 +2309 @@
         return currentPluginLoadPolicy;
 
-    RELEASE_ASSERT_NOT_REACHED(); // Please don't use any other plug-ins in tests, as they will not be installed on all machines.
+    // Please don't use any other plug-ins in tests, as they will not be installed on all machines.
+    RELEASE_ASSERT_NOT_REACHED_WITH_MESSAGE("Unexpected plugin bundle identifier: %s", toSTD(bundleIdentifier).c_str());
 #else
     return currentPluginLoadPolicy;