Changeset 254494 in webkit


Ignore:
Timestamp:
Jan 13, 2020 10:24:26 PM (4 years ago)
Author:
Ross Kirsling
Message:

Expose Phase on all WebWheelEvent implementations
https://bugs.webkit.org/show_bug.cgi?id=206195

Reviewed by Don Olmstead.

No change to behavior; just unhide what needn't be hidden.

  • Shared/WebEvent.h:

(WebKit::WebWheelEvent::directionInvertedFromDevice const):
(WebKit::WebWheelEvent::momentumPhase const):

  • Shared/WebWheelEvent.cpp:

(WebKit::WebWheelEvent::WebWheelEvent):

Location:
trunk/Source/WebKit
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r254489 r254494  
     12020-01-13  Ross Kirsling  <ross.kirsling@sony.com>
     2
     3        Expose Phase on all WebWheelEvent implementations
     4        https://bugs.webkit.org/show_bug.cgi?id=206195
     5
     6        Reviewed by Don Olmstead.
     7
     8        No change to behavior; just unhide what needn't be hidden.
     9
     10        * Shared/WebEvent.h:
     11        (WebKit::WebWheelEvent::directionInvertedFromDevice const):
     12        (WebKit::WebWheelEvent::momentumPhase const):
     13        * Shared/WebWheelEvent.cpp:
     14        (WebKit::WebWheelEvent::WebWheelEvent):
     15
    1162020-01-13  Don Olmstead  <don.olmstead@sony.com>
    217
  • trunk/Source/WebKit/Shared/WebEvent.h

    r253881 r254494  
    191191    };
    192192
    193 #if PLATFORM(COCOA) || PLATFORM(GTK) || PLATFORM(WPE)
    194193    enum Phase {
    195194        PhaseNone        = 0,
     
    201200        PhaseMayBegin    = 1 << 5,
    202201    };
    203 #endif
    204202
    205203    WebWheelEvent() { }
     
    218216    Granularity granularity() const { return static_cast<Granularity>(m_granularity); }
    219217    bool directionInvertedFromDevice() const { return m_directionInvertedFromDevice; }
    220 #if PLATFORM(COCOA) || PLATFORM(GTK) || PLATFORM(WPE)
    221218    Phase phase() const { return static_cast<Phase>(m_phase); }
    222219    Phase momentumPhase() const { return static_cast<Phase>(m_momentumPhase); }
    223 #endif
    224220#if PLATFORM(COCOA)
    225221    bool hasPreciseScrollingDeltas() const { return m_hasPreciseScrollingDeltas; }
     
    240236    uint32_t m_granularity; // Granularity
    241237    bool m_directionInvertedFromDevice;
    242 #if PLATFORM(COCOA) || PLATFORM(GTK) || PLATFORM(WPE)
    243238    uint32_t m_phase { Phase::PhaseNone };
    244239    uint32_t m_momentumPhase { Phase::PhaseNone };
    245 #endif
    246240#if PLATFORM(COCOA)
    247241    bool m_hasPreciseScrollingDeltas;
  • trunk/Source/WebKit/Shared/WebWheelEvent.cpp

    r241000 r254494  
    4242    , m_directionInvertedFromDevice(false)
    4343#if PLATFORM(COCOA)
    44     , m_phase(PhaseNone)
    4544    , m_hasPreciseScrollingDeltas(false)
    4645    , m_scrollCount(0)
Note: See TracChangeset for help on using the changeset viewer.