Changeset 254510 in webkit


Ignore:
Timestamp:
Jan 14, 2020 8:06:03 AM (4 years ago)
Author:
Antti Koivisto
Message:

[LFC][Integration] Support the feature flag in DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=206218

Reviewed by Zalan Bujtas.

Source/WebKitLegacy/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences layoutFormattingContextIntegrationEnabled]):
(-[WebPreferences setLayoutFormattingContextIntegrationEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Tools:

This allows tests to turn off the feature in WK1 if needed.

  • DumpRenderTree/TestOptions.cpp:

(TestOptions::TestOptions):

  • DumpRenderTree/TestOptions.h:
  • DumpRenderTree/mac/DumpRenderTree.mm:

(setWebPreferencesForTestOptions):

LayoutTests:

  • platform/mac-wk1/TestExpectations:
Location:
trunk
Files:
11 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r254506 r254510  
     12020-01-14  Antti Koivisto  <antti@apple.com>
     2
     3        [LFC][Integration] Support the feature flag in DumpRenderTree
     4        https://bugs.webkit.org/show_bug.cgi?id=206218
     5
     6        Reviewed by Zalan Bujtas.
     7
     8        * platform/mac-wk1/TestExpectations:
     9
    1102020-01-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
    211

  • trunk/LayoutTests/platform/mac-wk1/TestExpectations

    r254435 r254510  
    847847webkit.org/b/206071 editing/spelling/markers.html [ Skip ]
    848848webkit.org/b/206071 editing/spelling/retro-correction-spelling-markers.html [ Failure ]
    849 
    850 # These simple line layout specific tests disable LFC in test header. This is not supported in DRT.
    851 webkit.org/b/206167 fast/text/embed-at-end-of-pre-wrap-line-simple-lines.html [ ImageOnlyFailure ]
    852 webkit.org/b/206167 fast/text/simple-line-layout-leading-whitespace-with-soft-hard-linebreak.html [ ImageOnlyFailure ]
    853 webkit.org/b/206167 fast/text/simple-lines-float.html [ ImageOnlyFailure ]
    854 webkit.org/b/206167 fast/text/whitespace/pre-wrap-long-word-simple-lines.html [ ImageOnlyFailure ]

  • trunk/Source/WebKitLegacy/mac/ChangeLog

    r254317 r254510  
     12020-01-14  Antti Koivisto  <antti@apple.com>
     2
     3        [LFC][Integration] Support the feature flag in DumpRenderTree
     4        https://bugs.webkit.org/show_bug.cgi?id=206218
     5
     6        Reviewed by Zalan Bujtas.
     7
     8        * WebView/WebPreferenceKeysPrivate.h:
     9        * WebView/WebPreferences.mm:
     10        (+[WebPreferences initialize]):
     11        (-[WebPreferences layoutFormattingContextIntegrationEnabled]):
     12        (-[WebPreferences setLayoutFormattingContextIntegrationEnabled:]):
     13        * WebView/WebPreferencesPrivate.h:
     14        * WebView/WebView.mm:
     15        (-[WebView _preferencesChanged:]):
     16
    1172020-01-09  Tim Horton  <timothy_horton@apple.com>
    218

  • trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h

    r253655 r254510  
    206206#define WebKitWebAnimationsCSSIntegrationEnabledPreferenceKey @"WebKitWebAnimationsCSSIntegrationEnabled"
    207207#define WebKitCSSShadowPartsEnabledPreferenceKey @"WebKitCSSShadowPartsEnabled"
     208#define WebKitLayoutFormattingContextIntegrationEnabledPreferenceKey @"WebKitLayoutFormattingContextIntegrationEnabled"
    208209
    209210#if !TARGET_OS_IPHONE

  • trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm

    r254063 r254510  
    635635        @YES, WebKitModernMediaControlsEnabledPreferenceKey,
    636636        @YES, WebKitWebAnimationsCSSIntegrationEnabledPreferenceKey,
     637        @YES, WebKitLayoutFormattingContextIntegrationEnabledPreferenceKey,
    637638
    638639#if ENABLE(WEBGL2)
    … …  
    35943595}
    35953596
     3597- (BOOL)layoutFormattingContextIntegrationEnabled
     3598{
     3599    return [self _boolValueForKey:WebKitLayoutFormattingContextIntegrationEnabledPreferenceKey];
     3600}
     3601
     3602- (void)setLayoutFormattingContextIntegrationEnabled:(BOOL)flag
     3603{
     3604    [self _setBoolValue:flag forKey:WebKitLayoutFormattingContextIntegrationEnabledPreferenceKey];
     3605}
     3606
    35963607- (BOOL)remotePlaybackEnabled
    35973608{

  • trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h

    r253655 r254510  
    630630- (void)setCSSShadowPartsEnabled:(BOOL)flag;
    631631- (BOOL)cssShadowPartsEnabled;
     632
     633- (void)setLayoutFormattingContextIntegrationEnabled:(BOOL)flag;
     634- (BOOL)layoutFormattingContextIntegrationEnabled;
    632635
    633636- (BOOL)isInAppBrowserPrivacyEnabled;

  • trunk/Source/WebKitLegacy/mac/WebView/WebView.mm

    r254241 r254510  
    32063206    RuntimeEnabledFeatures::sharedFeatures().setKeygenElementEnabled([preferences keygenElementEnabled]);
    32073207    RuntimeEnabledFeatures::sharedFeatures().setCSSShadowPartsEnabled([preferences cssShadowPartsEnabled]);
     3208    RuntimeEnabledFeatures::sharedFeatures().setLayoutFormattingContextIntegrationEnabled([preferences layoutFormattingContextIntegrationEnabled]);
    32083209    RuntimeEnabledFeatures::sharedFeatures().setIsInAppBrowserPrivacyEnabled([preferences isInAppBrowserPrivacyEnabled]);
    32093210

  • trunk/Tools/ChangeLog

    r254509 r254510  
     12020-01-14  Antti Koivisto  <antti@apple.com>
     2
     3        [LFC][Integration] Support the feature flag in DumpRenderTree
     4        https://bugs.webkit.org/show_bug.cgi?id=206218
     5
     6        Reviewed by Zalan Bujtas.
     7
     8        This allows tests to turn off the feature in WK1 if needed.
     9
     10        * DumpRenderTree/TestOptions.cpp:
     11        (TestOptions::TestOptions):
     12        * DumpRenderTree/TestOptions.h:
     13        * DumpRenderTree/mac/DumpRenderTree.mm:
     14        (setWebPreferencesForTestOptions):
     15
    1162020-01-14  Alicia Boya García  <aboya@igalia.com>
    217

  • trunk/Tools/DumpRenderTree/TestOptions.cpp

    r253331 r254510  
    149149        else if (key == "experimental:AsyncClipboardAPIEnabled")
    150150            enableAsyncClipboardAPI = parseBooleanTestHeaderValue(value);
     151        else if (key == "internal:LayoutFormattingContextIntegrationEnabled")
     152            layoutFormattingContextIntegrationEnabled = parseBooleanTestHeaderValue(value);
    151153        pairStart = pairEnd + 1;
    152154    }

  • trunk/Tools/DumpRenderTree/TestOptions.h

    r251220 r254510  
    5454    bool enableRequestIdleCallback { false };
    5555    bool enableAsyncClipboardAPI { false };
     56    bool layoutFormattingContextIntegrationEnabled { true };
    5657    std::string jscOptions;
    5758    std::string additionalSupportedImageTypes;

  • trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm

    r254042 r254510  
    10361036    preferences.privateBrowsingEnabled = options.useEphemeralSession;
    10371037    preferences.usesPageCache = options.enableBackForwardCache;
     1038    preferences.layoutFormattingContextIntegrationEnabled = options.layoutFormattingContextIntegrationEnabled;
    10381039}
    10391040
Note: See TracChangeset for help on using the changeset viewer.