Changeset 254675 in webkit

Timestamp:

Jan 16, 2020 6:44:19 AM (4 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK][WPE] Password field doesn't get input method
​https://bugs.webkit.org/show_bug.cgi?id=34285

Reviewed by Žan Doberšek.

Source/WebCore:

Allow input methods in password fields for GTK and WPE ports, since the input methods are notified that the
active editable element is a password field.

• html/PasswordInputType.cpp:

(WebCore::PasswordInputType::shouldUseInputMethod const):

Tools:

Enable the test case for password field.

• TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:

(testWebKitInputMethodContextContentType):

Location:

trunk

Files:

• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/PasswordInputType.cpp (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK][WPE] Password field doesn't get input method
+        https://bugs.webkit.org/show_bug.cgi?id=34285
+
+        Reviewed by Žan Doberšek.
+
+        Allow input methods in password fields for GTK and WPE ports, since the input methods are notified that the
+        active editable element is a password field.
+
+        * html/PasswordInputType.cpp:
+        (WebCore::PasswordInputType::shouldUseInputMethod const):
+
 2020-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/Source/WebCore/html/PasswordInputType.cpp

@@ -65 +65 @@
 bool PasswordInputType::shouldUseInputMethod() const
 {
+#if PLATFORM(GTK) || PLATFORM(WPE)
+    // Input methods are enabled for the password field in GTK and WPE ports
+    // because the input methods are notified that the active editable element
+    // is a password field.
+    return true;
+#else
     // Input methods are disabled for the password field because otherwise
     // anyone can access the underlying password and display it in clear text.
     return false;
+#endif
 }
 

trunk/Tools/ChangeLog

@@ +1 @@
+2020-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK][WPE] Password field doesn't get input method
+        https://bugs.webkit.org/show_bug.cgi?id=34285
+
+        Reviewed by Žan Doberšek.
+
+        Enable the test case for password field.
+
+        * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
+        (testWebKitInputMethodContextContentType):
+
 2020-01-16  Cathie Chen  <cathiechen@igalia.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp

@@ -899 +899 @@
     test->unfocusEditableAndWaitUntilInputMethodDisabled();
 
-#if 0
-    // FIXME: We should enable input methods in password fields too.
-    test->loadHtml("<input id='editable' type='password'>", nullptr);
+    test->loadHtml("<input id='editable' type='password' spellcheck='false'>", nullptr);
     test->waitUntilLoadFinished();
     test->focusEditableAndWaitUntilInputMethodEnabled();
@@ -907 +905 @@
     g_assert_cmpuint(test->hints(), ==, WEBKIT_INPUT_HINT_NONE);
     test->unfocusEditableAndWaitUntilInputMethodDisabled();
-#endif
 
     test->loadHtml("<div contenteditable id='editable' inputmode='text' spellcheck='false'></div>", nullptr);