Changeset 254679 in webkit

Timestamp:

Jan 16, 2020 7:38:34 AM (4 years ago)

Author:

Antti Koivisto

Message:

[LFC][IFC] TextUtil::width should use StringView for substrings
​https://bugs.webkit.org/show_bug.cgi?id=206346

Reviewed by Zalan Bujtas.

• layout/inlineformatting/text/TextUtil.cpp:

(WebCore::Layout::TextUtil::width):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• layout/inlineformatting/text/TextUtil.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-01-16  Antti Koivisto  <antti@apple.com>
+
+        [LFC][IFC] TextUtil::width should use StringView for substrings
+        https://bugs.webkit.org/show_bug.cgi?id=206346
+
+        Reviewed by Zalan Bujtas.
+
+        * layout/inlineformatting/text/TextUtil.cpp:
+        (WebCore::Layout::TextUtil::width):
+
 2020-01-16  Takashi Komori  <Takashi.Komori@sony.com>
 

trunk/Source/WebCore/layout/inlineformatting/text/TextUtil.cpp

@@ -67 +67 @@
             width = fixedPitchWidth(text, style, from, to, contentLogicalLeft);
         else
-            width = font.widthForSimpleText(text.substring(from, to - from));
+            width = font.widthForSimpleText(StringView(text).substring(from, to - from));
     } else {
         auto tabWidth = style.collapseWhiteSpace() ? TabSize(0) : style.tabSize();
-        WebCore::TextRun run(text.substring(from, to - from), contentLogicalLeft);
+        WebCore::TextRun run(StringView(text).substring(from, to - from), contentLogicalLeft);
         if (tabWidth)
             run.setTabSize(true, tabWidth);