Changeset 25487 in webkit

Timestamp:

Sep 10, 2007 10:19:57 PM (17 years ago)

Author:

bdash

Message:

2007-09-10 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej Stachowiak.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=15157 Image defined in background-position: top center gets unexpectedly truncated <rdar://problem/5469095>

Test: fast/repaint/body-background-image.html

• rendering/RenderBox.cpp: (WebCore::RenderBox::imageChanged): Refined the logic for when the root takes over painting the background, to match paintBoxDecorations(). In particular, if the root has defined a background, the body should paint its own background.

2007-09-10 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej Stachowiak.

• repaint test for ​http://bugs.webkit.org/show_bug.cgi?id=15157 Image defined in background-position: top center gets unexpectedly truncated <rdar://problem/5469095>

• fast/repaint/body-background-image.html: Added.
• platform/mac/fast/repaint/body-background-image-expected.checksum: Added.
• platform/mac/fast/repaint/body-background-image-expected.png: Added.
• platform/mac/fast/repaint/body-background-image-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/repaint/body-background-image.html (added)
• LayoutTests/platform/mac/fast/repaint/body-background-image-expected.checksum (added)
• LayoutTests/platform/mac/fast/repaint/body-background-image-expected.png (added)
• LayoutTests/platform/mac/fast/repaint/body-background-image-expected.txt (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderBox.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-09-10  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Maciej Stachowiak.
+
+        - repaint test for http://bugs.webkit.org/show_bug.cgi?id=15157
+          Image defined in background-position: top center gets unexpectedly truncated
+          <rdar://problem/5469095>
+
+        * fast/repaint/body-background-image.html: Added.
+        * platform/mac/fast/repaint/body-background-image-expected.checksum: Added.
+        * platform/mac/fast/repaint/body-background-image-expected.png: Added.
+        * platform/mac/fast/repaint/body-background-image-expected.txt: Added.
+
 2007-09-10  David Harrison  <harrison@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-09-10  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Maciej Stachowiak.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=15157
+          Image defined in background-position: top center gets unexpectedly truncated
+          <rdar://problem/5469095>
+
+        Test: fast/repaint/body-background-image.html
+
+        * rendering/RenderBox.cpp:
+        (WebCore::RenderBox::imageChanged): Refined the logic for when the root takes
+        over painting the background, to match paintBoxDecorations(). In particular,
+        if the root has defined a background, the body should paint its own background.
+
 2007-09-10  David Harrison  <harrison@apple.com>
 

trunk/WebCore/rendering/RenderBox.cpp

@@ -469 +469 @@
     RenderBox* backgroundRenderer;
 
-    if (isBody() || isRoot()) {
+    if (isRoot() || (isBody() && document()->isHTMLDocument() && !document()->documentElement()->renderer()->style()->hasBackground())) {
         // Our background propagates to the root.
         backgroundRenderer = view();