Changeset 255130 in webkit


Ignore:
Timestamp:
Jan 26, 2020 1:11:08 PM (4 years ago)
Author:
eric.carlson@apple.com
Message:

media/modern-media-controls/media-controller/media-controller-auto-hide.html is flaky timing out
​https://bugs.webkit.org/show_bug.cgi?id=206629
<rdar://problem/58816827>

Reviewed by Dean Jackson.

Attempt to de-flake this test by decreasing the controller auto-hide interval and
using a base64 encoded video file to make it load and finish more quickly.

  • media/content/test.mp4.js: Added.

(base64MP4URL): Base64 encoded five frame, four second long MPEG-4 video.

  • media/modern-media-controls/media-controller/media-controller-auto-hide.html:
Location:
trunk/LayoutTests
Files:
1 added
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r255129 r255130  
     12020-01-26  Eric Carlson  <eric.carlson@apple.com>
     2
     3        media/modern-media-controls/media-controller/media-controller-auto-hide.html is flaky timing out
     4        https://bugs.webkit.org/show_bug.cgi?id=206629
     5        <rdar://problem/58816827>
     6
     7        Reviewed by Dean Jackson.
     8
     9        Attempt to de-flake this test by decreasing the controller auto-hide interval and
     10        using a base64 encoded video file to make it load and finish more quickly.
     11
     12        * media/content/test.mp4.js: Added.
     13        (base64MP4URL): Base64 encoded five frame, four second long MPEG-4 video.
     14        * media/modern-media-controls/media-controller/media-controller-auto-hide.html:
     15
    1162020-01-26  Rob Buis  <rbuis@igalia.com>
    217

  • trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide.html

    r223176 r255130  
    11<!DOCTYPE html>
    22<script src="../../../resources/js-test-pre.js"></script>
     3<script src="../resources/media-controls-loader.js" type="text/javascript"></script>
     4<script src="../resources/media-controls-utils.js" type="text/javascript"></script>
     5<script src="../../content/test.mp4.js"></script>
    36<body>
    4 <video src="../../content/test.mp4" style="position: absolute; left: 0; top: 0; width: 320px; height: 240px;" controls autoplay></video>
    5 <script type="text/javascript">
     7    <video style="position: absolute; left: 0; top: 0; width: 320px; height: 240px;" controls autoplay></video>
     8    <div id="host"></div>
    69
    7 window.jsTestIsAsync = true;
     10    <script type="text/javascript">
     11        window.jsTestIsAsync = true;
    812
    9 description("Testing the controls bar fades out as expected after the auto-hide delay expires upon first play.");
     13        description("Testing the controls bar fades out as expected after the auto-hide delay expires upon first play.");
    1014
    11 const media = document.querySelector("video");
    12 const shadowRoot = window.internals.shadowRoot(media);
     15        const media = document.querySelector("video");
     16        media.src = base64MP4URL();
    1317
    14 media.addEventListener("play", (event) => {
    15     shouldBecomeEqual("!!shadowRoot.querySelector('.media-controls')", "true", () => {
    16         shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "false", () => {
    17             shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "true", () => {
    18                 debug("");
    19                 media.remove();
    20                 finishJSTest();
     18        const shadowRoot = window.internals.shadowRoot(media);
     19        const container = document.querySelector("div#host");
     20        const mediaController = createControls(container, media, null);
     21
     22        mediaController.controls.autoHideController.autoHideDelay = 100;
     23        media.addEventListener("play", (event) => {
     24            shouldBecomeEqual("!!shadowRoot.querySelector('.media-controls')", "true", () => {
     25                shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "false", () => {
     26                    shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "true", () => {
     27                        debug("");
     28                        media.remove();
     29                        finishJSTest();
     30                    });
     31                });
    2132            });
    2233        });
    23     });
    24 });
     34    </script>
    2535
    26 </script>
    27 <script src="../../../resources/js-test-post.js"></script>
     36    <script src="../../../resources/js-test-post.js"></script>
     37
    2838</body>
Note: See TracChangeset for help on using the changeset viewer.