Changeset 255140 in webkit


Ignore:
Timestamp:
Jan 27, 2020 3:20:43 AM (4 years ago)
Author:
Antti Koivisto
Message:

[Mac wk2 Release] fast/dom/frame-src-javascript-url-async.html flaky failing
https://bugs.webkit.org/show_bug.cgi?id=206701
<rdar://problem/58847864>

Reviewed by Antoine Quint.

  • fast/dom/frame-src-javascript-url-async.html:

The test assumed that in

<iframe src=javascript:'foo'></iframe>
<script>

the frame javascript could not have run before the body script executes. However parser might yield before the
script tag or data might come from network in chunks that don't cover the full script. In this case frame load
may start and src execute before the body script runs.

Fix by document.writing the iframe tag.

Location:
trunk/LayoutTests
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r255131 r255140  
     12020-01-27  Antti Koivisto  <antti@apple.com>
     2
     3        [Mac wk2 Release] fast/dom/frame-src-javascript-url-async.html flaky failing
     4        https://bugs.webkit.org/show_bug.cgi?id=206701
     5        <rdar://problem/58847864>
     6
     7        Reviewed by Antoine Quint.
     8
     9        * fast/dom/frame-src-javascript-url-async.html:
     10
     11        The test assumed that in
     12
     13        <iframe src=javascript:'foo'></iframe>
     14        <script>
     15        …
     16
     17        the frame javascript could not have run before the body script executes. However parser might yield before the
     18        script tag or data might come from network in chunks that don't cover the full script. In this case frame load
     19        may start and src execute before the body script runs.
     20
     21        Fix by document.writing the iframe tag.
     22
    1232020-01-26  Said Abou-Hallawa  <said@apple.com>
    224
  • trunk/LayoutTests/fast/dom/frame-src-javascript-url-async.html

    r245012 r255140  
    2929</script>
    3030<iframe id="frame1"></iframe>
    31 <iframe id="frame2" src="javascript:'1'"></iframe>
    3231<script>
     32document.write("<iframe id=frame2 src=javascript:'1'></iframe>");
     33
    3334frame1 = document.getElementById("frame1");
    3435frame2 = document.getElementById("frame2");
Note: See TracChangeset for help on using the changeset viewer.