Changeset 255154 in webkit

Timestamp:

Jan 27, 2020 10:54:13 AM (4 years ago)

Author:

Devin Rousso

Message:

REGRESSION: [ Mac Debug WK1 ] inspector/page/overrideSetting-ICECandidateFilteringEnabled.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=206362
<rdar://problem/58649476>

Reviewed by Brian Burg.

Tentative fix. Modifying the iceCandidateFilteringEnabled WebCore setting causes any
existing/pending ICE candidates to immediately fire icecandidate events. Wait to change
the setting using Page.overrideSetting until after the JavaScript has set up the various
connections so that it's guaranteed to not miss any icecandidate events. Additionally
remove the default 10s timeout in case the debug build is too slow.

• inspector/page/overrideSetting-ICECandidateFilteringEnabled.html:
• inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt:
• platform/mac-wk1/TestExpectations:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt (modified) (1 diff)
• inspector/page/overrideSetting-ICECandidateFilteringEnabled.html (modified) (1 diff)
• platform/mac-wk1/TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-01-27  Devin Rousso  <drousso@apple.com>
+
+        REGRESSION: [ Mac Debug WK1 ] inspector/page/overrideSetting-ICECandidateFilteringEnabled.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=206362
+        <rdar://problem/58649476>
+
+        Reviewed by Brian Burg.
+
+        Tentative fix. Modifying the `iceCandidateFilteringEnabled` WebCore setting causes any
+        existing/pending ICE candidates to immediately fire `icecandidate` events. Wait to change
+        the setting using `Page.overrideSetting` until after the JavaScript has set up the various
+        connections so that it's guaranteed to not miss any `icecandidate` events. Additionally
+        remove the default 10s timeout in case the debug build is too slow.
+
+        * inspector/page/overrideSetting-ICECandidateFilteringEnabled.html:
+        * inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt:
+        * platform/mac-wk1/TestExpectations:
+
 2020-01-27  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt

@@ -4 +4 @@
 == Running test suite: Page.overrideSetting
 -- Running test case: Page.overrideSetting.ICECandidateFilteringEnabled
-Overriding ICECandidateFilteringEnabled to false...
 Creating data channel...
 PASS: created offer

trunk/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled.html

@@ -50 +50 @@
         description: "Test that changing whether ice candidate filtering is enabled has an effect.",
         async test() {
-            InspectorTest.log("Overriding ICECandidateFilteringEnabled to false...");
-            await PageAgent.overrideSetting(InspectorBackend.Enum.Page.Setting.ICECandidateFilteringEnabled, false);
-
             let [overriddenResult] = await Promise.all([
                 InspectorTest.awaitEvent("DataChannel"),
                 InspectorTest.evaluateInPage(`createDataChannel()`),
-            ])
+                PageAgent.overrideSetting(InspectorBackend.Enum.Page.Setting.ICECandidateFilteringEnabled, false),
+            ]);
             InspectorTest.expectThat(overriddenResult.data.success, "Should be able to establish a connection when filtering ice candidates.");
         },
+        timeout: -1,
     });
 

trunk/LayoutTests/platform/mac-wk1/TestExpectations

@@ -850 +850 @@
 webkit.org/b/199117 [ Debug ] storage/indexeddb/modern/objectstore-autoincrement-types.html [ Timeout ]
 
-webkit.org/b/206362 [ Debug ] inspector/page/overrideSetting-ICECandidateFilteringEnabled.html [ Failure Pass ]
-
 webkit.org/b/206503 [ Mojave ] imported/w3c/web-platform-tests/html/dom/idlharness.worker.html [ Failure ]