Changeset 255166 in webkit

Timestamp:

Jan 27, 2020 1:29:19 PM (4 years ago)

Author:

youenn@apple.com

Message:

[iOS Release and Mac Release] imported/w3c/web-platform-tests/webrtc/RTCDTMFSender-ontonechange.https.html is flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=206683
<rdar://problem/58841339>

Reviewed by Eric Carlson.

• web-platform-tests/webrtc/RTCDTMFSender-helper.js:

Move from async_test to promise_test to improve repeatability of the tests.

Location:

trunk/LayoutTests/imported/w3c

Files:

• ChangeLog (modified) (1 diff)
• web-platform-tests/webrtc/RTCDTMFSender-helper.js (modified) (3 diffs)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2020-01-27  youenn fablet  <youenn@apple.com>
+
+        [iOS Release and Mac Release] imported/w3c/web-platform-tests/webrtc/RTCDTMFSender-ontonechange.https.html is flaky failing
+        https://bugs.webkit.org/show_bug.cgi?id=206683
+        <rdar://problem/58841339>
+
+        Reviewed by Eric Carlson.
+
+        * web-platform-tests/webrtc/RTCDTMFSender-helper.js:
+        Move from async_test to promise_test to improve repeatability of the tests.
+
 2020-01-27  Antoine Quint  <graouts@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCDTMFSender-helper.js

@@ -79 +79 @@
  */
 function test_tone_change_events(testFunc, toneChanges, desc) {
-  async_test(t => {
+  promise_test(t => {
+    let done, fail;
+    const promise = new Promise((resolve, reject) => {
+        done = resolve;
+        fail = reject;
+    });
     const pc = new RTCPeerConnection();
 
@@ -125 +130 @@
           t.step_timeout(
             t.step_func(() => {
-              t.done();
+              done();
               pc.close();
               pc.otherPc.close();
@@ -138 +143 @@
       assert_unreached(`Unexpected promise rejection: ${err}`);
     }));
+    return promise;
   }, desc);
 }