Changeset 255171 in webkit

Timestamp:

Jan 27, 2020 1:46:35 PM (4 years ago)

Author:

ddkilzer@apple.com

Message:

REGRESSION (r250009): testair crashes in (anonymous namespace)::matchAll
<​https://webkit.org/b/206797>
<rdar://problem/58893221>

Reviewed by Yusuke Suzuki.

• b3/air/testair.cpp:

((anonymous namespace)::matchAll): Don't replace str in the
body of the for loop since match references it.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• b3/air/testair.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-01-27  David Kilzer  <ddkilzer@apple.com>
+
+        REGRESSION (r250009): testair crashes in (anonymous namespace)::matchAll
+        <https://webkit.org/b/206797>
+        <rdar://problem/58893221>
+
+        Reviewed by Yusuke Suzuki.
+
+        * b3/air/testair.cpp:
+        ((anonymous namespace)::matchAll): Don't replace `str` in the
+        body of the for loop since `match` references it.
+
 2020-01-27  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Source/JavaScriptCore/b3/air/testair.cpp

@@ -2070 +2070 @@
     Vector<String> matches;
     std::smatch match;
-    for (std::string str = source.data(); std::regex_search(str, match, regex);) {
+    for (std::string str = source.data(); std::regex_search(str, match, regex); str = match.suffix()) {
         ASSERT(match.size() == 1);
-        str = match.suffix();
         matches.append(match[0].str().c_str());
     }