Changeset 255220 in webkit

Timestamp:

Jan 27, 2020 6:20:39 PM (4 years ago)

Author:

commit-queue@webkit.org

Message:

Add WKWebView SPI equivalent of WKView.shouldClipToVisibleRect
​https://bugs.webkit.org/show_bug.cgi?id=206849
<rdar://problem/58887004>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-01-27
Reviewed by Simon Fraser.

Books currently uses WKView.setShouldClipToVisibleRect and needs to migrate to WKWebView, but it needs to do
so without modifying the other properties in _setMinimumLayoutWidth, which is currently the only other caller
of WebViewImpl::setClipsToVisibleRect. Expose an SPI that only calls WebViewImpl::setClipsToVisibleRect.

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/API/mac/WKWebViewMac.mm:

(-[WKWebView _clipsToVisibleRect]):
(-[WKWebView _setClipsToVisibleRect:]):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/Cocoa/WKWebViewPrivate.h (modified) (1 diff)
• UIProcess/API/mac/WKWebViewMac.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-01-27  Alex Christensen  <achristensen@webkit.org>
+
+        Add WKWebView SPI equivalent of WKView.shouldClipToVisibleRect
+        https://bugs.webkit.org/show_bug.cgi?id=206849
+        <rdar://problem/58887004>
+
+        Reviewed by Simon Fraser.
+
+        Books currently uses WKView.setShouldClipToVisibleRect and needs to migrate to WKWebView, but it needs to do
+        so without modifying the other properties in _setMinimumLayoutWidth, which is currently the only other caller
+        of WebViewImpl::setClipsToVisibleRect.  Expose an SPI that only calls WebViewImpl::setClipsToVisibleRect.
+
+        * UIProcess/API/Cocoa/WKWebViewPrivate.h:
+        * UIProcess/API/mac/WKWebViewMac.mm:
+        (-[WKWebView _clipsToVisibleRect]):
+        (-[WKWebView _setClipsToVisibleRect:]):
+
 2020-01-27  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h

@@ -517 +517 @@
 @property (nonatomic, readwrite, setter=_setIgnoresNonWheelEvents:) BOOL _ignoresNonWheelEvents WK_API_AVAILABLE(macos(10.13.4));
 
+/*! @abstract A Boolean value indicating whether drawing clips to the visibleRect.
+@discussion When YES, the view will use its -visibleRect when determining which areas of the WKWebView to draw. This may improve performance for large WKWebViews which are mostly clipped out by enclosing views.  The default value is NO.
+*/
+@property (nonatomic, readwrite, setter=_setClipsToVisibleRect:) BOOL _clipsToVisibleRect WK_API_AVAILABLE(macos(WK_MAC_TBA));
+
 @property (nonatomic, readonly) NSView *_safeBrowsingWarning WK_API_AVAILABLE(macos(10.14.4));
 

trunk/Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm

@@ -1401 +1401 @@
 }
 
+- (BOOL)_clipsToVisibleRect
+{
+    return _impl->clipsToVisibleRect();
+}
+
+- (void)_setClipsToVisibleRect:(BOOL)clipsToVisibleRect
+{
+    _impl->setClipsToVisibleRect(clipsToVisibleRect);
+}
+
 - (BOOL)_alwaysShowsHorizontalScroller
 {