Changeset 255331 in webkit


Ignore:
Timestamp:
Jan 28, 2020 5:57:25 PM (4 years ago)
Author:
Alan Bujtas
Message:

REGRESSION: [ Mac ] fast/hidpi/image-srcset-relative-svg-canvas-2x.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=206254
<rdar://problem/58580461>

Reviewed by Simon Fraser.

The drawImage() and the HTML document layout are racy here and when we
don't manage to squeeze in a layout before the JS drawImage(), the
SVG image gets laid out and rendered using the inline replaced box default size
value of 300x150. This patch only fixes the flakiness issue and
does not address the underlying bug (see webkit.org/b/206914).

  • fast/hidpi/image-srcset-relative-svg-canvas-2x-expected.html:
  • fast/hidpi/image-srcset-relative-svg-canvas-2x.html:
Location:
trunk/LayoutTests
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r255329 r255331  
     12020-01-28  Zalan Bujtas  <zalan@apple.com>
     2
     3        REGRESSION: [ Mac ] fast/hidpi/image-srcset-relative-svg-canvas-2x.html is a flaky failure
     4        https://bugs.webkit.org/show_bug.cgi?id=206254
     5        <rdar://problem/58580461>
     6
     7        Reviewed by Simon Fraser.
     8
     9        The drawImage() and the HTML document layout are racy here and when we
     10        don't manage to squeeze in a layout before the JS drawImage(), the
     11        SVG image gets laid out and rendered using the inline replaced box default size
     12        value of 300x150. This patch only fixes the flakiness issue and
     13        does not address the underlying bug (see webkit.org/b/206914).
     14
     15        * fast/hidpi/image-srcset-relative-svg-canvas-2x-expected.html:
     16        * fast/hidpi/image-srcset-relative-svg-canvas-2x.html:
     17
    1182020-01-28  Chris Dumez  <cdumez@apple.com>
    219
  • trunk/LayoutTests/fast/hidpi/image-srcset-relative-svg-canvas-2x-expected.html

    r163415 r255331  
    2424  <script>
    2525    window.addEventListener('load', function(){
     26        document.body.offsetHeight;
    2627        drawCanvas('svg10', 'canvas6', 100, 50);
    2728        if (window.testRunner)
  • trunk/LayoutTests/fast/hidpi/image-srcset-relative-svg-canvas-2x.html

    r163415 r255331  
    2525  <script>
    2626    window.addEventListener('load', function(){
     27        document.body.offsetHeight;
    2728        drawCanvas('svg10', 'canvas6', 100, 50);
    2829        if (window.testRunner)
Note: See TracChangeset for help on using the changeset viewer.