Changeset 25545 in webkit

Timestamp:

Sep 13, 2007 3:01:37 PM (17 years ago)

Author:

kmccullo

Message:

WebCore:

Reviewed by Geof, Sam, Adam, Hyatt, Darin.

• <rdar://problem/5480234> JS setTimeout function requires a second argument
• Removed check for number of arguments in setTimeout to behave like other browsers.
• Added layoutTest setTimeout-no-arguments.html

• bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):

LayoutTests:

Reviewed by Geof, Sam, Adam, Hyatt, Darin.

• <rdar://problem/5480234> JS setTimeout function requires a second argument
• Removed check for number of arguments in setTimeout to behave like other browsers.

• fast/dom/Window/setTimeout-no-arguments-expected.txt: Added.
• fast/dom/Window/setTimeout-no-arguments.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/Window/setTimeout-no-arguments-expected.txt (added)
• LayoutTests/fast/dom/Window/setTimeout-no-arguments.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/bindings/js/kjs_window.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-09-13  Kevin McCullough  <kmccullough@apple.com>
+
+        Reviewed by Geof, Sam, Adam, Hyatt, Darin.
+
+        - <rdar://problem/5480234> JS setTimeout function requires a second argument
+        - Removed check for number of arguments in setTimeout to behave like other browsers.
+
+        * fast/dom/Window/setTimeout-no-arguments-expected.txt: Added.
+        * fast/dom/Window/setTimeout-no-arguments.html: Added.
+
 2007-09-13  Antti Koivisto  <antti@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-09-13  Kevin McCullough  <kmccullough@apple.com>
+
+        Reviewed by Geof, Sam, Adam, Hyatt, Darin.
+
+        - <rdar://problem/5480234> JS setTimeout function requires a second argument
+        - Removed check for number of arguments in setTimeout to behave like other browsers.
+        - Added layoutTest setTimeout-no-arguments.html
+
+        * bindings/js/kjs_window.cpp:
+        (KJS::WindowFunc::callAsFunction):
+
 2007-09-13   Dave Hyatt  <hyatt@apple.com>
 

trunk/WebCore/bindings/js/kjs_window.cpp

@@ -1360 +1360 @@
     if (!window->isSafeScript(exec))
         return jsUndefined();
-    if (args.size() >= 2 && v->isString()) {
+    if (v->isString()) {
       int i = args[1]->toInt32(exec);
       int r = (const_cast<Window*>(window))->installTimeout(s, i, true /*single shot*/);
       return jsNumber(r);
     }
-    else if (args.size() >= 2 && v->isObject() && static_cast<JSObject *>(v)->implementsCall()) {
+    else if (v->isObject() && static_cast<JSObject *>(v)->implementsCall()) {
       JSValue *func = args[0];
       int i = args[1]->toInt32(exec);