Changeset 255495 in webkit

Timestamp:

Jan 31, 2020 7:44:40 AM (4 years ago)

Author:

Peng Liu

Message:

Media controls of the video player on nfl.com are not visible in fullscreen mode (iPad only)
​https://bugs.webkit.org/show_bug.cgi?id=207020

Reviewed by Eric Carlson.

Add a quirk to disable the element fullscreen API support for nfl.com on iPads.

• dom/DocumentFullscreen.idl:
• dom/Element.idl:
• page/Quirks.cpp:

(WebCore::Quirks::shouldDisableElementFullscreenQuirk const):

• page/Quirks.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/DocumentFullscreen.idl (modified) (1 diff)
• dom/Element.idl (modified) (2 diffs)
• page/Quirks.cpp (modified) (1 diff)
• page/Quirks.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-01-31  Peng Liu  <peng.liu6@apple.com>
+
+        Media controls of the video player on nfl.com are not visible in fullscreen mode (iPad only)
+        https://bugs.webkit.org/show_bug.cgi?id=207020
+
+        Reviewed by Eric Carlson.
+
+        Add a quirk to disable the element fullscreen API support for nfl.com on iPads.
+
+        * dom/DocumentFullscreen.idl:
+        * dom/Element.idl:
+        * page/Quirks.cpp:
+        (WebCore::Quirks::shouldDisableElementFullscreenQuirk const):
+        * page/Quirks.h:
+
 2020-01-31  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/dom/DocumentFullscreen.idl

@@ -27 +27 @@
     Conditional=FULLSCREEN_API,
     EnabledBySetting=FullScreen,
+    DisabledByQuirk=shouldDisableElementFullscreen
 ] partial interface Document {
     // Extensions from FullScreen API (https://fullscreen.spec.whatwg.org/#api).

trunk/Source/WebCore/dom/Element.idl

@@ -97 +97 @@
     // Extensions from Full Screen API (https://fullscreen.spec.whatwg.org/#api).
     // FIXME: Should we add unprefixed versions?
-    [Conditional=FULLSCREEN_API, EnabledBySetting=FullScreen, ImplementedAs=webkitRequestFullscreen] void webkitRequestFullScreen(); // Prefixed Mozilla version.
-    [Conditional=FULLSCREEN_API, EnabledBySetting=FullScreen] void webkitRequestFullscreen(); // Prefixed W3C version.
+    [Conditional=FULLSCREEN_API, EnabledBySetting=FullScreen, ImplementedAs=webkitRequestFullscreen, DisabledByQuirk=shouldDisableElementFullscreen] void webkitRequestFullScreen(); // Prefixed Mozilla version.
+    [Conditional=FULLSCREEN_API, EnabledBySetting=FullScreen, DisabledByQuirk=shouldDisableElementFullscreen] void webkitRequestFullscreen(); // Prefixed W3C version.
 
     // Extensions from Pointer Events API (https://w3c.github.io/pointerevents/#extensions-to-the-element-interface).
@@ -127 +127 @@
 
     // FIXME: These event handlers should only be on Document (https://fullscreen.spec.whatwg.org/#api).
-    [NotEnumerable, Conditional=FULLSCREEN_API, EnabledBySetting=FullScreen] attribute EventHandler onwebkitfullscreenchange;
-    [NotEnumerable, Conditional=FULLSCREEN_API, EnabledBySetting=FullScreen] attribute EventHandler onwebkitfullscreenerror;
+    [NotEnumerable, Conditional=FULLSCREEN_API, EnabledBySetting=FullScreen, DisabledByQuirk=shouldDisableElementFullscreen] attribute EventHandler onwebkitfullscreenchange;
+    [NotEnumerable, Conditional=FULLSCREEN_API, EnabledBySetting=FullScreen, DisabledByQuirk=shouldDisableElementFullscreen] attribute EventHandler onwebkitfullscreenerror;
 
     // FIXME: Cannot find those EventHandlers in the latest specification (https://w3c.github.io/uievents/#events-focus-types).

trunk/Source/WebCore/page/Quirks.cpp

@@ -628 +628 @@
 #endif
 
-}
+bool Quirks::shouldDisableElementFullscreenQuirk() const
+{
+#if PLATFORM(IOS_FAMILY)
+    if (!needsQuirks())
+        return false;
+
+    if (m_shouldDisableElementFullscreenQuirk)
+        return m_shouldDisableElementFullscreenQuirk.value();
+
+    auto domain = m_document->securityOrigin().domain().convertToASCIILowercase();
+
+    m_shouldDisableElementFullscreenQuirk = domain == "nfl.com" || domain.endsWith(".nfl.com");
+
+    return m_shouldDisableElementFullscreenQuirk.value();
+#else
+    return false;
+#endif
+}
+
+}

trunk/Source/WebCore/page/Quirks.h

@@ -88 +88 @@
 #endif
 
+    bool shouldDisableElementFullscreenQuirk() const;
+
 private:
     bool needsQuirks() const;
@@ -105 +107 @@
     mutable Optional<bool> m_needsPreloadAutoQuirk;
 #endif
+    mutable Optional<bool> m_shouldDisableElementFullscreenQuirk;
 };