Changeset 255552 in webkit


Ignore:
Timestamp:
Feb 2, 2020 3:18:47 PM (4 years ago)
Author:
commit-queue@webkit.org
Message:

ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html
​https://bugs.webkit.org/show_bug.cgi?id=207071
<rdar://problem/59076249>

Patch by Antoine Quint <Antoine Quint> on 2020-02-02
Reviewed by Dean Jackson.

Source/WebCore:

We cannot add CSSPropertyInvalid to a HashSet<CSSPropertyID>, because it triggers an ASSERT, and also we shouldn't
because we wouldn't know how to animate that CSS property.

  • animation/AnimationTimeline.cpp:

(WebCore::compileTransitionPropertiesInStyle):

LayoutTests:

The crash is fixed, we can start running the test as expected again.

  • platform/ipad/TestExpectations:
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r255545 r255552  
     12020-02-02  Antoine Quint  <graouts@apple.com>
     2
     3        ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html
     4        https://bugs.webkit.org/show_bug.cgi?id=207071
     5        <rdar://problem/59076249>
     6
     7        Reviewed by Dean Jackson.
     8
     9        The crash is fixed, we can start running the test as expected again.
     10
     11        * platform/ipad/TestExpectations:
     12
    1132020-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
    214

  • trunk/LayoutTests/platform/ipad/TestExpectations

    r255525 r255552  
    6464
    6565media/picture-in-picture [ Pass ]
    66 
    67 webkit.org/b/207071 [ Debug ] animations/keyframe-autoclose-brace.html [ Pass Crash ]

  • trunk/Source/WebCore/ChangeLog

    r255548 r255552  
     12020-02-02  Antoine Quint  <graouts@apple.com>
     2
     3        ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html
     4        https://bugs.webkit.org/show_bug.cgi?id=207071
     5        <rdar://problem/59076249>
     6
     7        Reviewed by Dean Jackson.
     8
     9        We cannot add CSSPropertyInvalid to a HashSet<CSSPropertyID>, because it triggers an ASSERT, and also we shouldn't
     10        because we wouldn't know how to animate that CSS property.
     11
     12        * animation/AnimationTimeline.cpp:
     13        (WebCore::compileTransitionPropertiesInStyle):
     14
    1152020-02-01  Michael Catanzaro  <mcatanzaro@gnome.org>
    216

  • trunk/Source/WebCore/animation/AnimationTimeline.cpp

    r255383 r255552  
    416416                for (size_t j = 0; j < shorthand.length(); ++j)
    417417                    transitionProperties.add(shorthand.properties()[j]);
    418             } else
     418            } else if (property != CSSPropertyInvalid)
    419419                transitionProperties.add(property);
    420420        } else if (mode == Animation::AnimateAll) {
Note: See TracChangeset for help on using the changeset viewer.