Changeset 255590 in webkit

Timestamp:

Feb 3, 2020 1:54:54 PM (4 years ago)

Author:

Lauro Moura

Message:

[WebKitTestRunner] setOpenPanelFiles support in non-local tests
​https://bugs.webkit.org/show_bug.cgi?id=206517

Reviewed by Carlos Alberto Lopez Perez.

Tools:

• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setOpenPanelFiles): Use ​file:// if the passed path
starts with a leading slash instead of using the test URL, which could
cause input forms with invalid file data.

LayoutTests:

• platform/gtk/TestExpectations: Update expectations after fix.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/TestExpectations (modified) (2 diffs)
• Tools/ChangeLog (modified) (1 diff)
• Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-02-03  Lauro Moura  <lmoura@igalia.com>
+
+        [WebKitTestRunner] setOpenPanelFiles support in non-local tests
+        https://bugs.webkit.org/show_bug.cgi?id=206517
+
+        Reviewed by Carlos Alberto Lopez Perez.
+
+        * platform/gtk/TestExpectations: Update expectations after fix.
+
 2020-02-03  Jacob Uphoff  <jacob_uphoff@apple.com>
 

trunk/LayoutTests/platform/gtk/TestExpectations

@@ -3833 +3833 @@
 webkit.org/b/193511 http/tests/images/mp4-partial-load.html [ Failure ]
 
-webkit.org/b/193516 http/tests/misc/form-submit-file-cross-site.html [ Failure ]
-
 webkit.org/b/193627 editing/spelling/spelling-dots-position.html [ ImageOnlyFailure ]
 
@@ -4099 +4097 @@
 webkit.org/b/204675 imported/w3c/web-platform-tests/offscreen-canvas/the-offscreen-canvas/initial.reset.pattern.worker.html [ Failure ]
 
-webkit.org/b/206517 http/tests/misc/form-submit-file-cross-site-redirect.html [ Failure ]
-webkit.org/b/206517 http/wpt/service-workers/file-upload.html [ Failure ]
+webkit.org/b/207016 http/tests/misc/form-submit-file-cross-site-redirect.html [ Failure ]
 
 webkit.org/b/206692 fast/canvas/canvas-fillPath-shadow.html [ Failure ]

trunk/Tools/ChangeLog

@@ +1 @@
+2020-02-03  Lauro Moura  <lmoura@igalia.com>
+
+        [WebKitTestRunner] setOpenPanelFiles support in non-local tests
+        https://bugs.webkit.org/show_bug.cgi?id=206517
+
+        Reviewed by Carlos Alberto Lopez Perez.
+
+        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
+        (WTR::TestRunner::setOpenPanelFiles): Use file:// if the passed path
+        starts with a leading slash instead of using the test URL, which could
+        cause input forms with invalid file data.
+
 2020-02-03  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp

@@ -2591 +2591 @@
         JSStringGetUTF8CString(file.get(), fileBuffer.get(), fileBufferSize);
 
-        WKArrayAppendItem(fileURLs.get(), adoptWK(WKURLCreateWithBaseURL(m_testURL.get(), fileBuffer.get())).get());
+        auto baseURL = m_testURL.get();
+
+        if (fileBuffer[0] == '/')
+            baseURL = WKURLCreateWithUTF8CString("file://");
+
+        WKArrayAppendItem(fileURLs.get(), adoptWK(WKURLCreateWithBaseURL(baseURL, fileBuffer.get())).get());
+
     }