Changeset 255593 in webkit

Timestamp:

Feb 3, 2020 2:16:46 PM (4 years ago)

Author:

graouts@webkit.org

Message:

[Web Animations] Accelerated animations don't run until their natural completion
​https://bugs.webkit.org/show_bug.cgi?id=207130
<rdar://problem/59106047>

Reviewed by Dean Jackson.

Source/WebCore:

Tests: webanimations/transform-accelerated-animation-finishes-before-removal.html

webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise.html

Ensure we don't tear down a composited renderer until all of its runnning accelerated animations are completed.
The accelerated animations will be queued for removal in the next animation frame.

• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::isRunningAcceleratedAnimationForProperty const):

• animation/KeyframeEffect.h:
• animation/KeyframeEffectStack.cpp:

(WebCore::KeyframeEffectStack::isCurrentlyAffectingProperty const):

LayoutTests:

Add two new tests that ensures that an accelerated animation still yields compositing on an element when
its finished promise is resolved, but that it's no longer the case on the next frame.

This required an existing test to be updated to wait until the next frame before checking the composited
status of an element on which an animation had just completed.

• compositing/geometry/limit-layer-bounds-opacity-transition.html:
• webanimations/transform-accelerated-animation-finishes-before-removal-expected.txt: Added.
• webanimations/transform-accelerated-animation-finishes-before-removal.html: Added.
• webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise-expected.txt: Added.
• webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/compositing/geometry/limit-layer-bounds-opacity-transition.html (modified) (1 diff)
• LayoutTests/webanimations/transform-accelerated-animation-finishes-before-removal-expected.txt (added)
• LayoutTests/webanimations/transform-accelerated-animation-finishes-before-removal.html (added)
• LayoutTests/webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise-expected.txt (added)
• LayoutTests/webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/animation/KeyframeEffect.cpp (modified) (1 diff)
• Source/WebCore/animation/KeyframeEffect.h (modified) (1 diff)
• Source/WebCore/animation/KeyframeEffectStack.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-02-03  Antoine Quint  <graouts@apple.com>
+
+        [Web Animations] Accelerated animations don't run until their natural completion
+        https://bugs.webkit.org/show_bug.cgi?id=207130
+        <rdar://problem/59106047>
+
+        Reviewed by Dean Jackson.
+
+        Add two new tests that ensures that an accelerated animation still yields compositing on an element when
+        its finished promise is resolved, but that it's no longer the case on the next frame.
+
+        This required an existing test to be updated to wait until the next frame before checking the composited
+        status of an element on which an animation had just completed.
+
+        * compositing/geometry/limit-layer-bounds-opacity-transition.html:
+        * webanimations/transform-accelerated-animation-finishes-before-removal-expected.txt: Added.
+        * webanimations/transform-accelerated-animation-finishes-before-removal.html: Added.
+        * webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise-expected.txt: Added.
+        * webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise.html: Added.
+
 2020-02-03  Jacob Uphoff  <jacob_uphoff@apple.com>
 

trunk/LayoutTests/compositing/geometry/limit-layer-bounds-opacity-transition.html

@@ -41 +41 @@
     {
       if (window.testRunner) {
-        document.getElementById('layers').innerText = window.internals.layerTreeAsText(document);
-        testRunner.notifyDone();
+          requestAnimationFrame(() => {
+              document.getElementById('layers').innerText = window.internals.layerTreeAsText(document);
+              testRunner.notifyDone();
+          })
       }
     }

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-02-03  Antoine Quint  <graouts@apple.com>
+
+        [Web Animations] Accelerated animations don't run until their natural completion
+        https://bugs.webkit.org/show_bug.cgi?id=207130
+        <rdar://problem/59106047>
+
+        Reviewed by Dean Jackson.
+
+        Tests: webanimations/transform-accelerated-animation-finishes-before-removal.html
+               webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise.html
+
+        Ensure we don't tear down a composited renderer until all of its runnning accelerated animations are completed.
+        The accelerated animations will be queued for removal in the next animation frame.
+
+        * animation/KeyframeEffect.cpp:
+        (WebCore::KeyframeEffect::isRunningAcceleratedAnimationForProperty const):
+        * animation/KeyframeEffect.h:
+        * animation/KeyframeEffectStack.cpp:
+        (WebCore::KeyframeEffectStack::isCurrentlyAffectingProperty const):
+
 2020-02-03  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/animation/KeyframeEffect.cpp

@@ -1108 +1108 @@
 }
 
+bool KeyframeEffect::isRunningAcceleratedAnimationForProperty(CSSPropertyID property) const
+{
+    return m_isRunningAccelerated && CSSPropertyAnimation::animationOfPropertyIsAccelerated(property) && m_blendingKeyframes.properties().contains(property);
+}
+
 void KeyframeEffect::invalidate()
 {

trunk/Source/WebCore/animation/KeyframeEffect.h

@@ -149 +149 @@
     enum class Accelerated : uint8_t { Yes, No };
     bool isCurrentlyAffectingProperty(CSSPropertyID, Accelerated = Accelerated::No) const;
+    bool isRunningAcceleratedAnimationForProperty(CSSPropertyID) const;
 
 private:

trunk/Source/WebCore/animation/KeyframeEffectStack.cpp

@@ -64 +64 @@
 {
     for (auto& effect : m_effects) {
-        if (effect->isCurrentlyAffectingProperty(property))
+        if (effect->isCurrentlyAffectingProperty(property) || effect->isRunningAcceleratedAnimationForProperty(property))
             return true;
     }