Changeset 255695 in webkit

Timestamp:

Feb 4, 2020 2:05:35 PM (4 years ago)

Author:

Jonathan Bedard

Message:

TestWebKitAPI: Handle case where test result does not contain path
​https://bugs.webkit.org/show_bug.cgi?id=207216

Reviewed by Tim Horton.

• TestWebKitAPI/TestsController.cpp:

(TestWebKitAPI::Printer::OnTestPartResult): It's possible that the TestPartResult
will not contain a file name. We should handle this case.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/TestsController.cpp (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-02-04  Jonathan Bedard  <jbedard@apple.com>
+
+        TestWebKitAPI: Handle case where test result does not contain path
+        https://bugs.webkit.org/show_bug.cgi?id=207216
+
+        Reviewed by Tim Horton.
+
+        * TestWebKitAPI/TestsController.cpp:
+        (TestWebKitAPI::Printer::OnTestPartResult): It's possible that the TestPartResult
+        will not contain a file name. We should handle this case.
+
 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
 

trunk/Tools/TestWebKitAPI/TestsController.cpp

@@ -1 +1 @@
 /*
- * Copyright (C) 2010 Apple Inc. All rights reserved.
+ * Copyright (C) 2010, 2020 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -41 +41 @@
 
         std::stringstream stream;
-        stream << "\n" << test_part_result.file_name() << ":" << test_part_result.line_number() << "\n" << test_part_result.summary() << "\n\n";
+        stream << "\n";
+        if (test_part_result.file_name())
+            stream << test_part_result.file_name() << ":" << test_part_result.line_number();
+        else
+            stream << "File name unavailable";
+        stream << "\n" << test_part_result.summary() << "\n\n";
         failures += stream.str();
     }