Changeset 255786 in webkit

Timestamp:

Feb 4, 2020 8:32:18 PM (4 years ago)

Author:

Wenson Hsieh

Message:

REGRESSION (r251320): Can't double tap to select word in Notes on iCloud.com
​https://bugs.webkit.org/show_bug.cgi?id=207239
<rdar://problem/58686015>

Reviewed by Tim Horton.

Source/WebKit:

Following r251320, all synthetic mouse events on iOS additionally dispatched corresponding pointer events. This
led to duplicate "pointerdown"/"pointerup" events dispatched with every tap. r253878 fixed this by avoiding
pointer event dispatch for synthetically generated mouse events (and made this determination by consulting
syntheticClickType()).

However, in the case where we're synthesizing a mouse event for a "dblclick" event handler (after a double-
tap), we currently pass NoTap as the synthetic click event type when creating the mouse event. This causes
additional pointer events to be synthesized and dispatched during a double tap, which creates three pairs of
"pointerdown"/"pointerup" events upon double-tap. This subsequently confuses iCloud Notes' web app when double
tapping to select a word.

Fix this by passing in OneFingerTap as the synthetic click type instead (since two-finger double taps should
already be handled by the two-finger double-tap magnification gesture).

Test: pointerevents/ios/pointer-events-for-double-tap.html

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleDoubleTapForDoubleClickAtPoint):

LayoutTests:

Add a test to verify that performing a double tap on an element with a dblclick handler results in the following
sequence of events: [ "pointerdown", "pointerup", "pointerdown", "pointerup", "dblclick" ].

• pointerevents/ios/pointer-events-for-double-tap-expected.txt: Added.
• pointerevents/ios/pointer-events-for-double-tap.html: Added.
• pointerevents/utils.js:

(const.ui.new.UIController.prototype.doubleTap):

Add a helper method to simulate a double-tap gesture.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/pointerevents/ios/pointer-events-for-double-tap-expected.txt (added)
• LayoutTests/pointerevents/ios/pointer-events-for-double-tap.html (added)
• LayoutTests/pointerevents/utils.js (modified) (1 diff)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        REGRESSION (r251320): Can't double tap to select word in Notes on iCloud.com
+        https://bugs.webkit.org/show_bug.cgi?id=207239
+        <rdar://problem/58686015>
+
+        Reviewed by Tim Horton.
+
+        Add a test to verify that performing a double tap on an element with a dblclick handler results in the following
+        sequence of events: `[ "pointerdown", "pointerup", "pointerdown", "pointerup", "dblclick" ]`.
+
+        * pointerevents/ios/pointer-events-for-double-tap-expected.txt: Added.
+        * pointerevents/ios/pointer-events-for-double-tap.html: Added.
+        * pointerevents/utils.js:
+        (const.ui.new.UIController.prototype.doubleTap):
+
+        Add a helper method to simulate a double-tap gesture.
+
 2020-02-04  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/LayoutTests/pointerevents/utils.js

@@ -133 +133 @@
     {
         return this._run(`uiController.singleTapAtPoint(${options.x}, ${options.y})`);
+    }
+
+    doubleTap(options)
+    {
+        return this._run(`uiController.doubleTapAtPoint(${options.x}, ${options.y}, 0, () => uiController.uiScriptComplete())`);
     }
 

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        REGRESSION (r251320): Can't double tap to select word in Notes on iCloud.com
+        https://bugs.webkit.org/show_bug.cgi?id=207239
+        <rdar://problem/58686015>
+
+        Reviewed by Tim Horton.
+
+        Following r251320, all synthetic mouse events on iOS additionally dispatched corresponding pointer events. This
+        led to duplicate "pointerdown"/"pointerup" events dispatched with every tap. r253878 fixed this by avoiding
+        pointer event dispatch for synthetically generated mouse events (and made this determination by consulting
+        `syntheticClickType()`).
+
+        However, in the case where we're synthesizing a mouse event for a "dblclick" event handler (after a double-
+        tap), we currently pass `NoTap` as the synthetic click event type when creating the mouse event. This causes
+        additional pointer events to be synthesized and dispatched during a double tap, which creates three pairs of
+        "pointerdown"/"pointerup" events upon double-tap. This subsequently confuses iCloud Notes' web app when double
+        tapping to select a word.
+
+        Fix this by passing in `OneFingerTap` as the synthetic click type instead (since two-finger double taps should
+        already be handled by the two-finger double-tap magnification gesture).
+
+        Test: pointerevents/ios/pointer-events-for-double-tap.html
+
+        * WebProcess/WebPage/ios/WebPageIOS.mm:
+        (WebKit::WebPage::handleDoubleTapForDoubleClickAtPoint):
+
 2020-02-01  Darin Adler  <darin@apple.com>
 

trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

@@ -834 +834 @@
     bool metaKey = modifiers.contains(WebEvent::Modifier::MetaKey);
     auto roundedAdjustedPoint = roundedIntPoint(adjustedPoint);
-    nodeRespondingToDoubleClick->document().frame()->eventHandler().handleMousePressEvent(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, LeftButton, PlatformEvent::MousePressed, 2, shiftKey, ctrlKey, altKey, metaKey, WallTime::now(), 0, WebCore::NoTap));
+    nodeRespondingToDoubleClick->document().frame()->eventHandler().handleMousePressEvent(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, LeftButton, PlatformEvent::MousePressed, 2, shiftKey, ctrlKey, altKey, metaKey, WallTime::now(), 0, WebCore::OneFingerTap));
     if (m_isClosed)
         return;
-    nodeRespondingToDoubleClick->document().frame()->eventHandler().handleMouseReleaseEvent(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, LeftButton, PlatformEvent::MouseReleased, 2, shiftKey, ctrlKey, altKey, metaKey, WallTime::now(), 0, WebCore::NoTap));
+    nodeRespondingToDoubleClick->document().frame()->eventHandler().handleMouseReleaseEvent(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, LeftButton, PlatformEvent::MouseReleased, 2, shiftKey, ctrlKey, altKey, metaKey, WallTime::now(), 0, WebCore::OneFingerTap));
 }