Changeset 255825 in webkit


Ignore:
Timestamp:
Feb 5, 2020 10:08:03 AM (4 years ago)
Author:
Chris Dumez
Message:

REGRESSION: [ iOS wk2 ] fast/scrolling/ios/scroll-events-back-forward.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207194
<rdar://problem/59148073>

Reviewed by Wenson Hsieh.

Test was flaky because it relied on a 10ms timer.

  • fast/scrolling/ios/scroll-events-back-forward-expected.txt:
  • fast/scrolling/ios/scroll-events-back-forward.html:
  • platform/ios-wk2/TestExpectations:
Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r255822 r255825  
     12020-02-05  Chris Dumez  <cdumez@apple.com>
     2
     3        REGRESSION: [ iOS wk2 ] fast/scrolling/ios/scroll-events-back-forward.html is flaky failing
     4        https://bugs.webkit.org/show_bug.cgi?id=207194
     5        <rdar://problem/59148073>
     6
     7        Reviewed by Wenson Hsieh.
     8
     9        Test was flaky because it relied on a 10ms timer.
     10
     11        * fast/scrolling/ios/scroll-events-back-forward-expected.txt:
     12        * fast/scrolling/ios/scroll-events-back-forward.html:
     13        * platform/ios-wk2/TestExpectations:
     14
    1152020-02-05  Jason Lawrence  <lawrence.j@apple.com>
    216
  • trunk/LayoutTests/fast/scrolling/ios/scroll-events-back-forward-expected.txt

    r200609 r255825  
    66pageshow 0
    77pageshow 1
    8 PASS scrollEventCount is 1
     8PASS scrollEventCount became 1
    99PASS successfullyParsed is true
    1010
  • trunk/LayoutTests/fast/scrolling/ios/scroll-events-back-forward.html

    r251220 r255825  
    33<html>
    44<head>
    5   <script src="../../../resources/js-test-pre.js"></script>
     5  <script src="../../../resources/js-test.js"></script>
    66  <style>
    77    body {
     
    1111</head>
    1212<body>
    13 <p id="description"></p>
    14 <div id="console"></div>
    15 
    1613<script>
    1714description('Tests that scroll event listeners still work after going back to a page in the page cache.');
     15jsTestIsAsync = true;
    1816
    1917function testScrollListener(message)
     
    3331  if (++pageShowCount == 2) {
    3432      testScrollListener('After going back');
    35       window.setTimeout(function() {
    36         shouldBe('scrollEventCount', '1');
    37         finishJSTest();
    38       }, 10);
    39     }
     33      shouldBecomeEqual('scrollEventCount', '1', finishJSTest);
     34  }
    4035}
    4136
     
    5045window.addEventListener('load', onPageLoad, false);
    5146window.addEventListener('pageshow', onPageShow, false);
    52 
    53 var successfullyParsed = true;
    54 var jsTestIsAsync = true;
    5547</script>
    56 
    57 <script src="../../../resources/js-test-post.js"></script>
    5848</body>
    5949</html>
  • trunk/LayoutTests/platform/ios-wk2/TestExpectations

    r255822 r255825  
    13741374webkit.org/b/207164 [ Debug ] legacy-animation-engine/animations/play-state-in-shorthand.html [ Pass Failure ]
    13751375
    1376 webkit.org/b/207194 fast/scrolling/ios/scroll-events-back-forward.html [ Pass Failure ]
    1377 
    13781376webkit.org/b/207197 http/tests/resourceLoadStatistics/cookie-deletion.html [ Pass Failure Crash ]
    13791377
Note: See TracChangeset for help on using the changeset viewer.