Changeset 255896 in webkit


Ignore:
Timestamp:
Feb 5, 2020 7:36:04 PM (4 years ago)
Author:
Nikita Vasilyev
Message:

Web Inspector: Some cookie table column headers should not be localizable
​https://bugs.webkit.org/show_bug.cgi?id=206920

Reviewed by Timothy Hatcher.

Keep headers that match cookie directives always in English.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Views/CookieStorageContentView.js:

(WI.CookieStorageContentView.prototype.initialLayout):

Location:
trunk/Source/WebInspectorUI
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebInspectorUI/ChangeLog

    r255894 r255896  
     12020-02-05  Nikita Vasilyev  <nvasilyev@apple.com>
     2
     3        Web Inspector: Some cookie table column headers should not be localizable
     4        https://bugs.webkit.org/show_bug.cgi?id=206920
     5
     6        Reviewed by Timothy Hatcher.
     7
     8        Keep headers that match cookie directives always in English.
     9
     10        * Localizations/en.lproj/localizedStrings.js:
     11        * UserInterface/Views/CookieStorageContentView.js:
     12        (WI.CookieStorageContentView.prototype.initialLayout):
     13
    1142020-02-05  Devin Rousso  <drousso@apple.com>
    215

  • trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

    r255887 r255896  
    534534localizedStrings["Expanded"] = "Expanded";
    535535localizedStrings["Experimental"] = "Experimental";
    536 localizedStrings["Expires"] = "Expires";
    537536localizedStrings["Export"] = "Export";
    538537localizedStrings["Export (%s)"] = "Export (%s)";

  • trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js

    r251227 r255896  
    181181        });
    182182
    183         this._domainColumn = new WI.TableColumn("domain", WI.UIString("Domain"), {
     183        this._domainColumn = new WI.TableColumn("domain", WI.unlocalizedString("Domain"), {
    184184            minWidth: 100,
    185185            maxWidth: 200,
    … …  
    187187        });
    188188
    189         this._pathColumn = new WI.TableColumn("path", WI.UIString("Path"), {
     189        this._pathColumn = new WI.TableColumn("path", WI.unlocalizedString("Path"), {
    190190            minWidth: 50,
    191191            maxWidth: 300,
    … …  
    193193        });
    194194
    195         this._expiresColumn = new WI.TableColumn("expires", WI.UIString("Expires"), {
     195        this._expiresColumn = new WI.TableColumn("expires", WI.unlocalizedString("Expires"), {
    196196            minWidth: 100,
    197197            maxWidth: 200,
Note: See TracChangeset for help on using the changeset viewer.