Changeset 255982 in webkit

Timestamp:

Feb 6, 2020 2:28:50 PM (4 years ago)

Author:

Devin Rousso

Message:

Web Inspector: REGRESSION(r249831): Sources: endless spinner when trying to view a resource
​https://bugs.webkit.org/show_bug.cgi?id=207346
<rdar://problem/59209016>

Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

• UserInterface/Workers/Formatter/HTMLParser.js:

(HTMLParser.prototype._parseAttr):
Attributes are allowed to contain "/".
​https://html.spec.whatwg.org/multipage/parsing.html#before-attribute-value-state

LayoutTests:

• inspector/formatting/resources/html-tests/attributes.html:
• inspector/formatting/resources/html-tests/attributes-expected.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/formatting/resources/html-tests/attributes-expected.html (modified) (1 diff)
• LayoutTests/inspector/formatting/resources/html-tests/attributes.html (modified) (1 diff)
• Source/WebInspectorUI/ChangeLog (modified) (1 diff)
• Source/WebInspectorUI/UserInterface/Workers/Formatter/HTMLParser.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-02-06  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: REGRESSION(r249831): Sources: endless spinner when trying to view a resource
+        https://bugs.webkit.org/show_bug.cgi?id=207346
+        <rdar://problem/59209016>
+
+        Reviewed by Timothy Hatcher.
+
+        * inspector/formatting/resources/html-tests/attributes.html:
+        * inspector/formatting/resources/html-tests/attributes-expected.html:
+
 2020-02-06  Truitt Savell  <tsavell@apple.com>
 

trunk/LayoutTests/inspector/formatting/resources/html-tests/attributes-expected.html

@@ -16 +16 @@
 <p attr=value1 attr=value2></p>
 <p a=1 b=2></p>
+<p href1=#fragment href2=/path/page.html href3=example.org href4=//example.org href5=http://example.org></p>
 
 <p a=1 b=2></p>

trunk/LayoutTests/inspector/formatting/resources/html-tests/attributes.html

@@ -16 +16 @@
 <p attr=value1 attr=value2></p>
 <p a=1 b=2></p>
+<p href1=#fragment href2=/path/page.html href3=example.org href4=//example.org href5=http://example.org></p>
 
 <p

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2020-02-06  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: REGRESSION(r249831): Sources: endless spinner when trying to view a resource
+        https://bugs.webkit.org/show_bug.cgi?id=207346
+        <rdar://problem/59209016>
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Workers/Formatter/HTMLParser.js:
+        (HTMLParser.prototype._parseAttr):
+        Attributes are allowed to contain "/".
+        https://html.spec.whatwg.org/multipage/parsing.html#before-attribute-value-state
+
 2020-02-06  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Workers/Formatter/HTMLParser.js

@@ -364 +364 @@
             }
 
-            let attributeValue = this._consumeRegex(/[^\s=/>]+/);
+            let attributeValue = this._consumeRegex(/[^\s=>]+/);
             this._pushAttribute({name: attributeName, value: attributeValue, quote: HTMLParser.AttrQuoteType.None, namePos: attributeNameStartPos, valuePos: attributeValueStartPos});
             return;