Changeset 256094 in webkit

Timestamp:

Feb 8, 2020 1:54:58 PM (4 years ago)

Author:

Alan Bujtas

Message:

[LFC][BFC] Box::isFloatAvoider should not check for isFloatingPositioned()
​https://bugs.webkit.org/show_bug.cgi?id=207429
<rdar://problem/59288204>

Reviewed by Antti Koivisto.

Box::isFloatAvoider() already checks for establishesBlockFormattingContext() (and floats do establish BFCs).

• layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::isFloatAvoider const):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• layout/layouttree/LayoutBox.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-02-08  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][BFC] Box::isFloatAvoider should not check for isFloatingPositioned()
+        https://bugs.webkit.org/show_bug.cgi?id=207429
+        <rdar://problem/59288204>
+
+        Reviewed by Antti Koivisto.
+
+        Box::isFloatAvoider() already checks for establishesBlockFormattingContext() (and floats do establish BFCs). 
+
+        * layout/layouttree/LayoutBox.cpp:
+        (WebCore::Layout::Box::isFloatAvoider const):
+
 2020-02-08  Sam Weinig  <weinig@apple.com>
 

trunk/Source/WebCore/layout/layouttree/LayoutBox.cpp

@@ -195 +195 @@
 bool Box::isFloatAvoider() const
 {
-    return establishesBlockFormattingContext() || establishesTableFormattingContext() || isFloatingPositioned() || hasFloatClear();
+    return establishesBlockFormattingContext() || establishesTableFormattingContext() || hasFloatClear();
 }