Changeset 256113 in webkit

Timestamp:

Feb 10, 2020 2:13:38 AM (4 years ago)

Author:

eocanha@igalia.com

Message:

[GTK] Mouse pointer no longer hidden during fullscreen video playback
​https://bugs.webkit.org/show_bug.cgi?id=197346

Reviewed by Adrian Perez de Castro.

.:

Enabled the CURSOR_VISIBILITY feature on the GTK port.

• Source/cmake/OptionsGTK.cmake:

Source/WebKit:

Covered by existing tests.

• UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves): Added implementation.

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp (modified) (1 diff)
• Source/cmake/OptionsGTK.cmake (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2020-02-10  Enrique Ocaña González  <eocanha@igalia.com>
+
+        [GTK] Mouse pointer no longer hidden during fullscreen video playback
+        https://bugs.webkit.org/show_bug.cgi?id=197346
+
+        Reviewed by Adrian Perez de Castro.
+
+        Enabled the CURSOR_VISIBILITY feature on the GTK port.
+
+        * Source/cmake/OptionsGTK.cmake:
+
 2020-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-02-10  Enrique Ocaña González  <eocanha@igalia.com>
+
+        [GTK] Mouse pointer no longer hidden during fullscreen video playback
+        https://bugs.webkit.org/show_bug.cgi?id=197346
+
+        Reviewed by Adrian Perez de Castro.
+
+        Covered by existing tests.
+
+        * UIProcess/API/gtk/PageClientImpl.cpp:
+        (WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves): Added implementation.
+
 2020-02-10  Adrian Perez de Castro  <aperez@igalia.com>
 

trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp

@@ -156 +156 @@
 }
 
-void PageClientImpl::setCursorHiddenUntilMouseMoves(bool /* hiddenUntilMouseMoves */)
-{
-    notImplemented();
+void PageClientImpl::setCursorHiddenUntilMouseMoves(bool hiddenUntilMouseMoves)
+{
+    if (!hiddenUntilMouseMoves)
+        return;
+
+    setCursor(WebCore::noneCursor());
+
+    // There's no need to set a timer to restore the cursor by hand. It will
+    // be automatically restored when the mouse moves.
 }
 

trunk/Source/cmake/OptionsGTK.cmake

@@ -152 +152 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_AUTOCAPITALIZE PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CONTENT_EXTENSIONS PRIVATE ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CURSOR_VISIBILITY PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DARK_MODE_CSS PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DATALIST_ELEMENT PRIVATE ON)