Changeset 256129 in webkit
- Timestamp:
- Feb 10, 2020 5:23:36 AM (4 years ago)
- Location:
- releases/WebKitGTK/webkit-2.28/Source/WebKit
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
releases/WebKitGTK/webkit-2.28/Source/WebKit/ChangeLog
r256125 r256129 1 2020-02-06 Chris Dumez <cdumez@apple.com> 2 3 REGRESSION (r254706): Crash under WebProcessPool::terminateServiceWorkerProcess() 4 https://bugs.webkit.org/show_bug.cgi?id=207354 5 <rdar://problem/59184818> 6 7 Reviewed by Geoffrey Garen. 8 9 No new tests, not easily testable AFAIK since this happens on failure to send sync IPC to 10 the service worker when terminating it. 11 12 * UIProcess/WebProcessPool.cpp: 13 (WebKit::WebProcessPool::terminateServiceWorkerProcess): 14 'auto' resolved to 'WeakPtr<WebProcessProxy>' in this method and the call to 15 disableServiceWorkers() could cause the process to get destroyed. We would then 16 do a null dereference on the next line. 17 1 18 2020-02-10 Adrian Perez de Castro <aperez@igalia.com> 2 19 -
releases/WebKitGTK/webkit-2.28/Source/WebKit/UIProcess/WebProcessPool.cpp
r255952 r256129 1780 1780 #if ENABLE(SERVICE_WORKER) 1781 1781 auto protectedThis = makeRef(*this); 1782 if ( auto process = m_serviceWorkerProcesses.get({ domain, sessionID })) {1782 if (RefPtr<WebProcessProxy> process = m_serviceWorkerProcesses.get({ domain, sessionID }).get()) { 1783 1783 process->disableServiceWorkers(); 1784 1784 process->requestTermination(ProcessTerminationReason::ExceededCPULimit);
Note: See TracChangeset
for help on using the changeset viewer.