Changeset 256302 in webkit

Timestamp:

Feb 11, 2020 5:09:59 AM (4 years ago)

Author:

commit-queue@webkit.org

Message:

[WPE][WebDriver] MiniBrowser should react to close session commands
​https://bugs.webkit.org/show_bug.cgi?id=207529

Patch by Lauro Moura <Lauro Moura> on 2020-02-11
Reviewed by Carlos Garcia Campos.

WebDriver delete session command asks to close the WebView associated to the
current automation session. We must react to it to avoid lots of
timeouts and errors.

• MiniBrowser/wpe/main.cpp:

(main): Listen to "close" signal on the main WebView.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• MiniBrowser/wpe/main.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-02-11  Lauro Moura  <lmoura@igalia.com>
+
+        [WPE][WebDriver] MiniBrowser should react to close session commands
+        https://bugs.webkit.org/show_bug.cgi?id=207529
+
+        Reviewed by Carlos Garcia Campos.
+
+        WebDriver delete session command asks to close the WebView associated to the
+        current automation session. We must react to it to avoid lots of
+        timeouts and errors.
+
+        * MiniBrowser/wpe/main.cpp:
+        (main): Listen to "close" signal on the main WebView.
+
 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Tools/MiniBrowser/wpe/main.cpp

@@ -301 +301 @@
     g_signal_connect(webView, "permission-request", G_CALLBACK(decidePermissionRequest), nullptr);
     g_signal_connect(webView, "create", G_CALLBACK(createWebView), nullptr);
+    g_signal_connect(webView, "close", G_CALLBACK(webViewClose), nullptr);
 
     if (ignoreTLSErrors)